Use equals instead of == for descriptor comparison

Author: dmlloyd

src/main/java/io/github/dmlloyd/classfile/CodeBuilder.java

@@ -554,7 +554,7 @@ default CodeBuilder conversion(TypeKind fromType, TypeKind toType) {
      */
     default CodeBuilder loadConstant(ConstantDesc value) {
         //avoid switch expressions here
-        if (value == null || value == ConstantDescs.NULL)
+        if (value == null || value.equals(ConstantDescs.NULL))
             return aconst_null();
         if (value instanceof Number) {
             if (value instanceof Integer) return loadConstant((int)    value);

src/main/java/io/github/dmlloyd/classfile/impl/StackMapGenerator.java

@@ -975,12 +975,12 @@ public String toString() {
         }
 
         Frame pushStack(ClassDesc desc) {
-            if (desc == CD_long)   return pushStack(Type.LONG_TYPE, Type.LONG2_TYPE);
-            if (desc == CD_double) return pushStack(Type.DOUBLE_TYPE, Type.DOUBLE2_TYPE);
-            return desc == CD_void ? this
+            if (desc.equals(CD_long))   return pushStack(Type.LONG_TYPE, Type.LONG2_TYPE);
+            if (desc.equals(CD_double)) return pushStack(Type.DOUBLE_TYPE, Type.DOUBLE2_TYPE);
+            return desc.equals(CD_void) ? this
                     : pushStack(
                     desc.isPrimitive()
-                            ? (desc == CD_float ? Type.FLOAT_TYPE : Type.INTEGER_TYPE)
+                            ? (desc.equals(CD_float) ? Type.FLOAT_TYPE : Type.INTEGER_TYPE)
                             : Type.referenceType(desc));
         }
 
@@ -1078,18 +1078,18 @@ void setLocalsFromArg(String name, MethodTypeDesc methodDesc, boolean isStatic,
             }
             for (int i = 0; i < methodDesc.parameterCount(); i++) {
                 var desc = methodDesc.parameterType(i);
-                if (desc == CD_long) {
+                if (desc.equals(CD_long)) {
                     locals[localsSize    ] = Type.LONG_TYPE;
                     locals[localsSize + 1] = Type.LONG2_TYPE;
                     localsSize += 2;
-                } else if (desc == CD_double) {
+                } else if (desc.equals(CD_double)) {
                     locals[localsSize    ] = Type.DOUBLE_TYPE;
                     locals[localsSize + 1] = Type.DOUBLE2_TYPE;
                     localsSize += 2;
                 } else {
                     if (!desc.isPrimitive()) {
                         type = Type.referenceType(desc);
-                    } else if (desc == CD_float) {
+                    } else if (desc.equals(CD_float)) {
                         type = Type.FLOAT_TYPE;
                     } else {
                         type = Type.INTEGER_TYPE;

src/main/java/io/github/dmlloyd/classfile/impl/Util.java

@@ -243,15 +243,15 @@ static void writeList(BufWriterImpl buf, Writable[] array, int size) {
     }
 
     public static int slotSize(ClassDesc desc) {
-        return desc == CD_void ? 0 : isDoubleSlot(desc) ? 2 : 1;
+        return desc.equals(CD_void) ? 0 : isDoubleSlot(desc) ? 2 : 1;
     }
 
     public static int paramSlotSize(ClassDesc desc) {
         return isDoubleSlot(desc) ? 2 : 1;
     }
 
     public static boolean isDoubleSlot(ClassDesc desc) {
-        return desc == CD_double || desc == CD_long;
+        return desc.equals(CD_double) || desc.equals(CD_long);
     }
 
     public static void dumpMethod(SplitConstantPool cp,