fix(chipingress): set explicit bucket boundaries for request_size_bytes histogram#2136
Open
pkcll wants to merge 2 commits into
Open
fix(chipingress): set explicit bucket boundaries for request_size_bytes histogram#2136pkcll wants to merge 2 commits into
pkcll wants to merge 2 commits into
Conversation
product-security-plaid-production
Bot
requested review from
4of9,
engnke,
fouadkada,
hendoxc,
kirqz23 and
thomaska
|
👋 pkcll, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
📊 API Diff Results
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Chip Ingress batch client metrics to use explicit histogram bucket boundaries for the PublishBatch request size (bytes), improving the usefulness/consistency of the exported *_bucket series.
Changes:
- Add explicit bucket boundaries (1 KiB → 10 MiB) for
chip_ingress.batch.request_size_byteshistogram.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pkcll
force-pushed
the
chipingress-batch-req-size-hist-buckets
branch
from
5321e66 to
824d8d5
Compare
thomaska
approved these changes
Jun 9, 2026
kirqz23
approved these changes
Jun 9, 2026
jmank88
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set explicit bucket boundaries for
chip_ingress_batch_request_size_bytes_buckethistogram