Popover with tooltip not closing

[felhag]

Please provide the environment you discovered this bug in.

<div class="flex flex-row">
	<hlm-popover>
		<div>
			<button hlmPopoverTrigger hlmBtn hlmTooltipTrigger="Open popover">Open popover</button>
		</div>
		<div hlmPopoverContent *brnPopoverContent>
			Content
		</div>
	</hlm-popover>
	<hlm-popover>
		<div>
			<button hlmPopoverTrigger hlmBtn hlmTooltipTrigger="Open other popover">Open other popover</button>
		</div>
		<div hlmPopoverContent *brnPopoverContent>
			Content
		</div>
	</hlm-popover>
</div>

When the first popover is open and you click the second popover button the first stays open.

Which area/package is the issue in?

popover

Description

When a popover is open and you click on a button with hlmTooltipTrigger the popover stays open. The reason for this seems this check in brn-dialog.service.ts:

cdkDialogRef.outsidePointerEvents.pipe(takeUntil(destroyed$)).subscribe(() => {
	// only close if this is the topmost overlay
	if (this._overlayCloseDispatcher._attachedOverlays.at(-1) === cdkDialogRef.overlayRef) {
		brnDialogRef.close(undefined, options?.closeDelay);
	}
});

Not sure what the right approach is for this. Maybe an exception for tooltips should be added?

Please provide the exception or error you saw

Other information

No response

I would be willing to submit a PR to fix this issue

• Yes
• No

[MerlinMoos]

Good catch i stumbled today over the same issue. When you need help let me know. I believe that @ashley-hunter is having an idea for a fix

[ashley-hunter]

Yes, I believe this comment here should resolve the issue:

#1059 (comment)

I have had very little time this last week or so, so havent had a chance to raise a PR yet - but it should be fairly easy to fix 😊

[felhag]

I figured I could simply add a check to see if the overlays are nested, if not, we can still proceed with the dialog close. This was a little more difficult than I would've expect in first instance 😅. This is what I came up with, but surely there should be an easier way to figure out if those dialogs are nested? Also had a look at the PR @ashley-hunter mentioned but since not every overlay is opened through the dialog-service I don't think we can rely on the open function.

[ashley-hunter]

Yes, it's very possible there is more than one issue here 😊 it sounded very similar to the other issue, so I thought they might be related, but we may need something like you are suggesting. I do recall having to do something like that in the past too.

[felhag]

Hmm okay, in that case I created a PR, please shoot... :)