SPL-298478: Add App CRD on M1 milestone branch#1826
Merged
Conversation
|
There are some merge conflicts, can we rebase and push again |
naimulh247
reviewed
Apr 10, 2026
naimulh247
left a comment
naimulh247
left a comment
There was a problem hiding this comment.
we might want to consider using pointers as part of the app_types.go to know if user defined the field or not
jzywiecki
force-pushed
the
mvp/app-framework-v1-app-crd
branch
from
bffa2f9 to
86350ea
Compare
vivekr-splunk
requested changes
Apr 10, 2026
Collaborator
vivekr-splunk
left a comment
vivekr-splunk
left a comment
There was a problem hiding this comment.
I found two blocking issues in the current App CRD/controller shape.
jzywiecki
force-pushed
the
mvp/app-framework-v1-app-crd
branch
from
99d10eb to
f5518fe
Compare
jzywiecki
changed the title
jzywiecki
changed the title
Signed-off-by: jzywieck <jzywiecki@splunk.com>
Signed-off-by: jzywieck <jzywiecki@splunk.com>
Signed-off-by: jzywieck <jzywiecki@splunk.com>
Signed-off-by: jzywieck <jzywiecki@splunk.com>
jzywiecki
force-pushed
the
mvp/app-framework-v1-app-crd
branch
from
b80ace9 to
43688f2
Compare
need to update the description |
naimulh247
reviewed
Apr 16, 2026
| Path string `json:"path"` | ||
| } | ||
|
|
||
| // AppSourceSpec defines the app source details. |
Author
There was a problem hiding this comment.
Thank you for the catch! Fixed
| // Phase of the app resource | ||
| Phase string `json:"phase,omitempty"` | ||
|
|
||
| // Auxillary message describing CR status |
Author
There was a problem hiding this comment.
Adjusted the typo, thank you!
Signed-off-by: jzywieck <jzywiecki@splunk.com>
Signed-off-by: jzywieck <jzywiecki@splunk.com>
Author
|
I have addressed the comments, manually tested the app spec added changes and updated the results in PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the new
Appcustom resource definition to the operator.Key Changes
AppAPI type underapps.splunk.com/v1alpha1AppCRDAppmanifest and wired it into sample kustomizationTesting and Verification
make manifests generateFields that must be set validation:
appID: Unique identifier of the application
version: Desired application version
targetRef:
kind
name
sourceRef: Reference to an AppSource resource
package:
path: Path to the application package within the source
scope: Deployment scope definition
Successful config:
Related Issues
Screenshots
PR Checklist