From a65a408787d787c1170d7dc5ee513b851799b67c Mon Sep 17 00:00:00 2001 From: Arjan Date: Thu, 30 Jul 2026 08:14:14 +0530 Subject: [PATCH 1/2] test: migrate `math/base/special/aversin` to ULP difference testing --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../math/base/special/aversin/test/test.js | 26 +++++-------------- .../base/special/aversin/test/test.native.js | 26 +++++-------------- 2 files changed, 14 insertions(+), 38 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/aversin/test/test.js b/lib/node_modules/@stdlib/math/base/special/aversin/test/test.js index c730d8777809..2ec997375562 100644 --- a/lib/node_modules/@stdlib/math/base/special/aversin/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/aversin/test/test.js @@ -22,8 +22,8 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var randu = require( '@stdlib/random/base/randu' ); -var abs = require( '@stdlib/math/base/special/abs' ); var EPS = require( '@stdlib/constants/float64/eps' ); var aversin = require( './../lib' ); @@ -44,48 +44,36 @@ tape( 'main export is a function', function test( t ) { tape( 'the function computes the inverse versed sine', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; x = data.x; expected = data.expected; for ( i = 0; i < x.length; i++ ) { y = aversin( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 15.0 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + e = expected[ i ]; + t.strictEqual( isAlmostSameValue( y, e, 21 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function computes the inverse versed sine (small positive numbers)', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; x = smallPositive.x; expected = smallPositive.expected; for ( i = 0; i < x.length; i++ ) { y = aversin( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + e = expected[ i ]; + t.strictEqual( isAlmostSameValue( y, e, 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/aversin/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/aversin/test/test.native.js index 8e79c6bf5d87..2e78febb4d1f 100644 --- a/lib/node_modules/@stdlib/math/base/special/aversin/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/aversin/test/test.native.js @@ -23,8 +23,8 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var randu = require( '@stdlib/random/base/randu' ); -var abs = require( '@stdlib/math/base/special/abs' ); var EPS = require( '@stdlib/constants/float64/eps' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -53,48 +53,36 @@ tape( 'main export is a function', opts, function test( t ) { tape( 'the function computes the inverse versed sine', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; x = data.x; expected = data.expected; for ( i = 0; i < x.length; i++ ) { y = aversin( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 350.0 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + e = expected[ i ]; + t.strictEqual( isAlmostSameValue( y, e, 350 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function computes the inverse versed sine (small positive numbers)', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; x = smallPositive.x; expected = smallPositive.expected; for ( i = 0; i < x.length; i++ ) { y = aversin( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + e = expected[ i ]; + t.strictEqual( isAlmostSameValue( y, e, 350 ), true, 'returns expected value' ); } t.end(); }); From ec751e58c35f8e64f3737a0856d7baa0d504256b Mon Sep 17 00:00:00 2001 From: Arjan Date: Thu, 30 Jul 2026 10:31:34 +0530 Subject: [PATCH 2/2] fix: adjust to min ULP in test.native.js --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/math/base/special/aversin/test/test.native.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/aversin/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/aversin/test/test.native.js index 2e78febb4d1f..3b6834198b79 100644 --- a/lib/node_modules/@stdlib/math/base/special/aversin/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/aversin/test/test.native.js @@ -64,7 +64,7 @@ tape( 'the function computes the inverse versed sine', opts, function test( t ) for ( i = 0; i < x.length; i++ ) { y = aversin( x[i] ); e = expected[ i ]; - t.strictEqual( isAlmostSameValue( y, e, 350 ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( y, e, 21 ), true, 'returns expected value' ); } t.end(); }); @@ -82,7 +82,7 @@ tape( 'the function computes the inverse versed sine (small positive numbers)', for ( i = 0; i < x.length; i++ ) { y = aversin( x[i] ); e = expected[ i ]; - t.strictEqual( isAlmostSameValue( y, e, 350 ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( y, e, 1 ), true, 'returns expected value' ); } t.end(); });