Skip to content

Commit 2126f3e

Browse files
committed
chore: add unit tests
1 parent 8e0ce51 commit 2126f3e

File tree

91 files changed

+7000
-1834
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

91 files changed

+7000
-1834
lines changed

src/main/java/com/taosdata/jdbc/AbstractConnection.java

Lines changed: 36 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import java.util.*;
99
import java.util.concurrent.*;
1010
import java.util.concurrent.atomic.AtomicLong;
11-
11+
@SuppressWarnings("java:S4144")
1212
public abstract class AbstractConnection extends WrapperImpl implements Connection {
1313

1414
protected final AtomicLong idGenerator = new AtomicLong(0);
@@ -47,7 +47,8 @@ public boolean canRebalanced() {
4747
}
4848
@Override
4949
public CallableStatement prepareCall(String sql) throws SQLException {
50-
return notSupportedMethod();
50+
checkClosed();
51+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
5152
}
5253

5354
@Override
@@ -204,17 +205,20 @@ public PreparedStatement prepareStatement(String sql, int resultSetType, int res
204205

205206
@Override
206207
public CallableStatement prepareCall(String sql, int resultSetType, int resultSetConcurrency) throws SQLException {
207-
return notSupportedMethod();
208+
checkClosed();
209+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
208210
}
209211

210212
@Override
211213
public Map<String, Class<?>> getTypeMap() throws SQLException {
212-
return notSupportedMethod();
214+
checkClosed();
215+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
213216
}
214217

215218
@Override
216219
public void setTypeMap(Map<String, Class<?>> map) throws SQLException {
217-
notSupportedMethod();
220+
checkClosed();
221+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
218222
}
219223

220224
@Override
@@ -243,21 +247,25 @@ public int getHoldability() throws SQLException {
243247

244248
@Override
245249
public Savepoint setSavepoint() throws SQLException {
246-
return notSupportedMethod();
250+
checkClosed();
251+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
247252
}
248253

249254
@Override
250255
public Savepoint setSavepoint(String name) throws SQLException {
251-
return notSupportedMethod();
256+
checkClosed();
257+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
252258
}
253259

254260
@Override
255261
public void rollback(Savepoint savepoint) throws SQLException {
256-
notSupportedMethod();
262+
checkClosed();
263+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
257264
}
258265
@Override
259266
public void releaseSavepoint(Savepoint savepoint) throws SQLException {
260-
notSupportedMethod();
267+
checkClosed();
268+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
261269
}
262270

263271
@Override
@@ -289,7 +297,8 @@ public PreparedStatement prepareStatement(String sql, int resultSetType, int res
289297

290298
@Override
291299
public CallableStatement prepareCall(String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability) throws SQLException {
292-
return notSupportedMethod();
300+
checkClosed();
301+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
293302
}
294303

295304
@Override
@@ -308,34 +317,40 @@ public PreparedStatement prepareStatement(String sql, int autoGeneratedKeys) thr
308317

309318
@Override
310319
public PreparedStatement prepareStatement(String sql, int[] columnIndexes) throws SQLException {
311-
return notSupportedMethod();
320+
checkClosed();
321+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
312322
}
313323

314324
@Override
315325
public PreparedStatement prepareStatement(String sql, String[] columnNames) throws SQLException {
316-
return notSupportedMethod();
326+
checkClosed();
327+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
317328
}
318329

319330
@Override
320331
public Clob createClob() throws SQLException {
321-
return notSupportedMethod();
332+
checkClosed();
333+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
322334
}
323335

324336
@Override
325337
public Blob createBlob() throws SQLException {
326-
return notSupportedMethod();
338+
checkClosed();
339+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
327340

328341
}
329342

330343
@Override
331344
public NClob createNClob() throws SQLException {
332-
return notSupportedMethod();
345+
checkClosed();
346+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
333347

334348
}
335349

336350
@Override
337351
public SQLXML createSQLXML() throws SQLException {
338-
return notSupportedMethod();
352+
checkClosed();
353+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
339354
}
340355

341356
@Override
@@ -414,12 +429,14 @@ public Properties getClientInfo() throws SQLException {
414429

415430
@Override
416431
public Array createArrayOf(String typeName, Object[] elements) throws SQLException {
417-
return notSupportedMethod();
432+
checkClosed();
433+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
418434
}
419435

420436
@Override
421437
public Struct createStruct(String typeName, Object[] attributes) throws SQLException {
422-
return notSupportedMethod();
438+
checkClosed();
439+
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
423440
}
424441

425442
@Override
@@ -499,11 +516,7 @@ public int writeRaw(String line, SchemalessProtocolType protocolType, Schemaless
499516
}
500517

501518
public abstract int writeRaw(String line, SchemalessProtocolType protocolType, SchemalessTimestampType timestampType, Integer ttl, Long reqId) throws SQLException;
502-
503-
protected <T> T notSupportedMethod() throws SQLException {
504-
checkClosed();
505-
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_UNSUPPORTED_METHOD);
506-
}
519+
507520
private void checkClosed() throws SQLException {
508521
if (this.isClosed) {
509522
throw TSDBError.createSQLException(TSDBErrorNumbers.ERROR_CONNECTION_CLOSED);

src/main/java/com/taosdata/jdbc/AbstractDatabaseMetaData.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import com.google.common.collect.Lists;
44
import com.taosdata.jdbc.enums.DataType;
5-
import com.taosdata.jdbc.rs.ConnectionParam;
5+
import com.taosdata.jdbc.common.ConnectionParam;
66
import com.taosdata.jdbc.utils.StringUtils;
77
import com.taosdata.jdbc.ws.WSConnection;
88
import org.slf4j.Logger;

src/main/java/com/taosdata/jdbc/AbstractDriver.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import com.fasterxml.jackson.databind.ObjectMapper;
66
import com.fasterxml.jackson.databind.ObjectReader;
77
import com.taosdata.jdbc.enums.WSFunction;
8-
import com.taosdata.jdbc.rs.ConnectionParam;
8+
import com.taosdata.jdbc.common.ConnectionParam;
99
import com.taosdata.jdbc.utils.*;
1010
import com.taosdata.jdbc.ws.*;
1111
import com.taosdata.jdbc.ws.entity.*;

0 commit comments

Comments
 (0)