As was suggested in an earlier PR review comment, testing other people's code is not a priority, so ? is unnecessary in many places. Furthermore, opting for .expect or .unwrap, which cause the program to terminate immediately with a very detailed stack trace may be advantageous compared to ?, since ? will cause errors to bubble up, thus losing context. At the very least, we should opt for a more powerful error library to add more context to errors in localic-utils.
Suggested Changes
- Remove usages of
? in localic-utils where more detailed error information could be important or useful
As was suggested in an earlier PR review comment, testing other people's code is not a priority, so
?is unnecessary in many places. Furthermore, opting for.expector.unwrap, which cause the program to terminate immediately with a very detailed stack trace may be advantageous compared to?, since?will cause errors to bubble up, thus losing context. At the very least, we should opt for a more powerful error library to add more context to errors in localic-utils.Suggested Changes
?in localic-utils where more detailed error information could be important or useful