feat: add SwiftLint build plugin and fix all linting issues

Author: tornikegomareli

Package.swift

@@ -1,4 +1,4 @@
-// swift-tools-version: 6.1
+// swift-tools-version: 6.0
 // The swift-tools-version declares the minimum version of Swift required to build this package.
 
 import PackageDescription
@@ -13,23 +13,29 @@ let package = Package(
         .visionOS(.v1)
     ],
     products: [
-        // Products define the executables and libraries a package produces, making them visible to other packages.
         .library(
             name: "SwiftLRUCache",
             targets: ["SwiftLRUCache"]),
     ],
+    dependencies: [
+        .package(url: "https://github.com/realm/SwiftLint.git", from: "0.54.0")
+    ],
     targets: [
-        // Targets are the basic building blocks of a package, defining a module or a test suite.
-        // Targets can depend on other targets in this package and products from dependencies.
         .target(
             name: "SwiftLRUCache",
             swiftSettings: [
                 .enableExperimentalFeature("StrictConcurrency")
+            ],
+            plugins: [
+                .plugin(name: "SwiftLintBuildToolPlugin", package: "SwiftLint")
             ]
         ),
         .testTarget(
             name: "SwiftLRUCacheTests",
-            dependencies: ["SwiftLRUCache"]
+            dependencies: ["SwiftLRUCache"],
+            plugins: [
+                .plugin(name: "SwiftLintBuildToolPlugin", package: "SwiftLint")
+            ]
         ),
     ]
 )

Tests/SwiftLRUCacheTests/AdvancedOperationsTests.swift

@@ -4,7 +4,6 @@ import Foundation
 
 @Suite("Advanced Operations Tests")
 struct AdvancedOperationsTests {
-
     @Test("pop removes and returns LRU item")
     func testPop() throws {
         let config = try Configuration<String, Int>(max: 3)
@@ -173,7 +172,7 @@ struct AdvancedOperationsTests {
 
     @Test("dump with TTL and size info")
     func testDumpWithMetadata() throws {
-        var config = try Configuration<String, Data>(maxSize: 1024, ttl: 60)
+        var config = try Configuration<String, Data>(maxSize: 1_024, ttl: 60)
         config.sizeCalculation = { value, _ in value.count }
 
         let cache = LRUCache<String, Data>(configuration: config)
@@ -192,4 +191,4 @@ struct AdvancedOperationsTests {
         #expect(dump.contains("(size: 200)"))
         #expect(dump.contains("(TTL:")) // Should show remaining TTL
     }
-}
+}

Tests/SwiftLRUCacheTests/BasicLRUCacheTests.swift

@@ -4,7 +4,6 @@ import Foundation
 
 @Suite("Basic LRU Cache Tests")
 struct BasicLRUCacheTests {
-
     @Test("Cache can be initialized with configuration")
     func testCacheInitialization() throws {
         let config = try Configuration<String, Int>(max: 100)
@@ -165,4 +164,4 @@ struct BasicLRUCacheTests {
         #expect(disposedItems[0].1 == 1)
         #expect(disposedItems[0].2 == .evict)
     }
-}
+}

Tests/SwiftLRUCacheTests/ConfigurationTests.swift

@@ -4,7 +4,6 @@ import Foundation
 
 @Suite("Configuration Tests")
 struct ConfigurationTests {
-
     @Test("Configuration requires at least one constraint")
     func testConfigurationRequiresConstraint() throws {
         #expect(throws: ConfigurationError.noConstraints) {
@@ -22,7 +21,7 @@ struct ConfigurationTests {
 
     @Test("Configuration accepts maxSize constraint")
     func testConfigurationWithMaxSize() throws {
-        let config = try Configuration<String, String>(maxSize: 1024)
+        let config = try Configuration<String, String>(maxSize: 1_024)
         #expect(config.max == nil)
         #expect(config.maxSize == 1024)
         #expect(config.ttl == nil)
@@ -38,7 +37,7 @@ struct ConfigurationTests {
 
     @Test("Configuration accepts multiple constraints")
     func testConfigurationWithMultipleConstraints() throws {
-        let config = try Configuration<String, String>(max: 100, maxSize: 1024, ttl: 300)
+        let config = try Configuration<String, String>(max: 100, maxSize: 1_024, ttl: 300)
         #expect(config.max == 100)
         #expect(config.maxSize == 1024)
         #expect(config.ttl == 300)
@@ -111,7 +110,7 @@ struct ConfigurationTests {
 
     @Test("Configuration accepts size calculation function")
     func testConfigurationWithSizeCalculation() throws {
-        var config = try Configuration<String, Data>(maxSize: 1024)
+        var config = try Configuration<String, Data>(maxSize: 1_024)
         config.sizeCalculation = { value, _ in
             value.count
         }
@@ -125,11 +124,13 @@ struct ConfigurationTests {
 
     @Test("Configuration validates maxEntrySize")
     func testConfigurationMaxEntrySize() throws {
-        var config = try Configuration<String, String>(maxSize: 1024)
+        var config = try Configuration<String, String>(maxSize: 1_024)
         config.maxEntrySize = 512
 
         #expect(config.maxEntrySize == 512)
-        #expect(config.maxEntrySize! <= config.maxSize!)
+        if let maxEntrySize = config.maxEntrySize, let maxSize = config.maxSize {
+            #expect(maxEntrySize <= maxSize)
+        }
     }
 
     @Test("Configuration is a value type")
@@ -142,4 +143,4 @@ struct ConfigurationTests {
         #expect(config1.ttl == nil)
         #expect(config2.ttl == 300)
     }
-}
+}

Tests/SwiftLRUCacheTests/LRUCacheTests.swift

@@ -4,3 +4,4 @@ import Testing
 @Suite("LRU Cache Integration Tests")
 struct LRUCacheTests {}
 
+

Tests/SwiftLRUCacheTests/NodeTests.swift

@@ -52,10 +52,10 @@ struct NodeTests {
 
     @Test("Node can store size metadata")
     func testNodeSizeMetadata() {
-        let node = LRUNode<String, Data>(key: "data", value: Data(repeating: 0, count: 1024))
-        node.size = 1024
+        let node = LRUNode<String, Data>(key: "data", value: Data(repeating: 0, count: 1_024))
+        node.size = 1_024
 
-        #expect(node.size == 1024)
+        #expect(node.size == 1_024)
     }
 
     @Test("Node can store TTL metadata")
@@ -105,4 +105,4 @@ struct NodeTests {
         #expect(node1.prev === node2)
         #expect(node1.next === node3)
     }
-}
+}

Tests/SwiftLRUCacheTests/SizeTrackingTests.swift

@@ -4,7 +4,6 @@ import Foundation
 
 @Suite("Size Tracking Tests")
 struct SizeTrackingTests {
-
     @Test("Cache respects maxSize constraint")
     func testMaxSizeConstraint() throws {
         var config = try Configuration<String, Data>(maxSize: 1024) // 1KB max
@@ -114,7 +113,7 @@ struct SizeTrackingTests {
             let age: Int
 
             var estimatedSize: Int {
-                return name.count + 8 // String chars + Int size
+                name.count + 8 // String chars + Int size
             }
         }
 
@@ -156,7 +155,7 @@ struct SizeTrackingTests {
 
     @Test("Cache without size calculation defaults to count-based eviction")
     func testNoSizeCalculation() throws {
-        let config = try Configuration<String, Data>(maxSize: 1024)
+        let config = try Configuration<String, Data>(maxSize: 1_024)
         // No sizeCalculation provided
         let cache = LRUCache<String, Data>(configuration: config)
 
@@ -226,4 +225,4 @@ struct SizeTrackingTests {
         #expect(cache.size == 2) // Limited by size
         #expect(cache.calculatedSize <= 500)
     }
-}
+}

Tests/SwiftLRUCacheTests/TTLTests.swift

@@ -162,4 +162,4 @@ struct TTLTests {
         #expect(disposedItems.count >= 2) // Both expired items should be disposed
         #expect(cache.size == 1) // Only key3 should remain
     }
-}
+}