Skip to content

chore: allow utopia-php/cache 2.0.* alongside 1.0.* #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChiragAgg5k wants to merge 1 commit into from
+1 −1
Closed

chore: allow utopia-php/cache 2.0.* alongside 1.0.* #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"require": {
"php": ">=8.2",
"utopia-php/validators": "0.*",
"utopia-php/cache": "1.0.*"
"utopia-php/cache": "1.0.* || 2.0.*"
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 CI does not validate both cache versions

The test plan checkbox ("CI passes against both cache 1.0.x and 2.0.x") is unchecked, and the existing test.yml workflow has no matrix axis for cache version. composer install will resolve to the highest matching version (2.0.*), so 1.0.x is never installed and exercised post-merge. Adding a cache-versions: ['1.0.*', '2.0.*'] matrix dimension and running composer require utopia-php/cache:${{ matrix.cache-versions }} --no-update before composer install would verify both constraints are actually satisfied.

},
"require-dev": {
"phpunit/phpunit": "^9.3",
Expand Down
Loading