sanitize deleteCount to not exceed length / amount of items from index to end

BoussonKarel · BoussonKarel · commit 9506e09ce2d9 · 2025-11-24T12:16:23.000+01:00
diff --git a/warp-drive-packages/core/src/store/-private/record-arrays/legacy-many-array.ts b/warp-drive-packages/core/src/store/-private/record-arrays/legacy-many-array.ts
@@ -342,8 +342,11 @@ function _MUTATE<T>(
         }
       }
 
+      // sanitize deleteCount to not exceed length / amount of items from index to end
+      deleteCount = Math.min(collection[Context].source.length - start, deleteCount);
+
       // detect a full replace
-      if (start === 0 && deleteCount >= collection[Context].source.length) {
+      if (start === 0 && deleteCount === collection[Context].source.length) {
         const newValues = extractIdentifiersFromRecords(adds);
 
         assertNoDuplicates(

Original file line number	Diff line number	Diff line change
`@@ -342,8 +342,11 @@ function _MUTATE<T>(`
`342`	`342`	`}`
`343`	`343`	`}`
`344`	`344`
	`345`	`+ // sanitize deleteCount to not exceed length / amount of items from index to end`
	`346`	`+ deleteCount = Math.min(collection[Context].source.length - start, deleteCount);`
	`347`	`+`
`345`	`348`	`// detect a full replace`
`346`		`- if (start === 0 && deleteCount >= collection[Context].source.length) {`
	`349`	`+ if (start === 0 && deleteCount === collection[Context].source.length) {`
`347`	`350`	`const newValues = extractIdentifiersFromRecords(adds);`
`348`	`351`
`349`	`352`	`assertNoDuplicates(`