-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Pagination utils #10014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leoeuclids
wants to merge
22
commits into
warp-drive-data:main
Choose a base branch
from
leoeuclids:pagination-utils-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pagination utils #10014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoeuclids
commented
May 27, 2025
warp-drive-packages/core/src/store/-private/new-core-tmp/paginated-state.ts
Outdated
Show resolved
Hide resolved
leoeuclids
commented
May 27, 2025
warp-drive-packages/core/src/store/-private/new-core-tmp/paginated-state.ts
Outdated
Show resolved
Hide resolved
leoeuclids
commented
May 27, 2025
warp-drive-packages/core/src/store/-private/new-core-tmp/paginated-state.ts
Outdated
Show resolved
Hide resolved
leoeuclids
commented
May 27, 2025
warp-drive-packages/core/src/store/-private/new-core-tmp/paginated-state.ts
Outdated
Show resolved
Hide resolved
addbe82 to
3ee3dde
Compare
da009bd to
fa52113
Compare
fa52113 to
ebe805f
Compare
ebe805f to
ccb6fe2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is a migration from the work done on #9452
This PR introduces a suite of data-utilities for pagination to go along with
PromiseState / <Await />andRequestState / <Request />Docs (in PR)
Implementation Tracking
Below the Line Features
(features we intend to bake into these primitives but may not be added in this PR)
Note
We do not intend for
<Paginate />to be used to manage Tree and LinkedListstructures, which inherently have different requirements around async loading
and pagination. We are planning a separate suite of data-utils for these structures
in the near future.