Skip to content

Commit e34524d

Browse files
committed
2 parents 728de4e + e172abc commit e34524d

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

dist/dynamic-forms.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,22 +108,22 @@
108108

109109
vm.showError = function () {
110110
var field = $scope.formField;
111-
return field && field.$invalid && field.$dirty;
111+
return !!(field && field.$invalid && field.$dirty);
112112
};
113113

114114
vm.showSuccess = function () {
115115
var field = $scope.formField;
116-
return field && field.$valid && field.$dirty;
116+
return !!(field && field.$valid && field.$dirty);
117117
};
118118

119119
vm.hasError = function() {
120120
var field = $scope.formField;
121-
return field.errorMessage && field.$dirty;
121+
return !!($scope.errorMessage && field.$dirty);
122122
};
123123

124124
vm.hasSuccess = function() {
125125
var field = $scope.formField;
126-
return field.$valid && ($scope.model || field.$dirty);
126+
return !!(field.$valid && ($scope.model || field.$dirty));
127127
};
128128
}
129129

@@ -688,12 +688,14 @@
688688

689689
scope.$watch(function () {
690690
if (!formField.$invalid) {
691+
scope.errorKey = null;
691692
scope.errorMessage = null;
692693
return;
693694
}
694695

695696
for (var key in formField.$error) {
696697
if (formField.$error[key] === true) {
698+
scope.errorKey = key;
697699
scope.errorMessage = getErrorMessage(fieldSchema, key);
698700
break;
699701
}

dist/dynamic-forms.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/directives/dynamicFieldDirective.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,22 @@
66

77
vm.showError = function () {
88
var field = $scope.formField;
9-
return field && field.$invalid && field.$dirty;
9+
return !!(field && field.$invalid && field.$dirty);
1010
};
1111

1212
vm.showSuccess = function () {
1313
var field = $scope.formField;
14-
return field && field.$valid && field.$dirty;
14+
return !!(field && field.$valid && field.$dirty);
1515
};
1616

1717
vm.hasError = function() {
1818
var field = $scope.formField;
19-
return field.errorMessage && field.$dirty;
19+
return !!($scope.errorMessage && field.$dirty);
2020
};
2121

2222
vm.hasSuccess = function() {
2323
var field = $scope.formField;
24-
return field.$valid && ($scope.model || field.$dirty);
24+
return !!(field.$valid && ($scope.model || field.$dirty));
2525
};
2626
}
2727

src/services/validationProvider.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,14 @@
7070

7171
scope.$watch(function () {
7272
if (!formField.$invalid) {
73+
scope.errorKey = null;
7374
scope.errorMessage = null;
7475
return;
7576
}
7677

7778
for (var key in formField.$error) {
7879
if (formField.$error[key] === true) {
80+
scope.errorKey = key;
7981
scope.errorMessage = getErrorMessage(fieldSchema, key);
8082
break;
8183
}

0 commit comments

Comments
 (0)