-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Open
Labels
feat: view transitionsRelated to the View Transitions feature (scope)Related to the View Transitions feature (scope)
Milestone
Description
Description
I was updating the astro:transitions reference in docs (withastro/docs#12734) to add some undocumented APIs. Based on @martrapp feedbacks there, we might want to deprecate some APIs:
createAnimationScope()isTransitionBeforePreparationEvent()isTransitionBeforeSwapEvent()TRANSITION_BEFORE_PREPARATIONTRANSITION_AFTER_PREPARATIONTRANSITION_BEFORE_SWAPTRANSITION_AFTER_SWAPTRANSITION_PAGE_LOAD
This seems reasonable to me. But, I'm not the framework expert here so let me know if there is any reasons not to do that. (ie., so far, I was thinking documenting everything (because some are used) except createAnimationScope()... if we don't want to deprecate createAnimationScope(), I need to know for docs)
I also noted that:
- ClientRouterModule, TransitionModule from
astro:transitionsare importable while those are internal types - EventModule, TransitionRouterModule, TransitionSwapFunctionModule from
astro:transitions/clientare importable while those are internal types
Not a big deal, but maybe we want to prevent that with a clean up similar to the one Florian has suggested for astro:actions in #14608 (comment)
Metadata
Metadata
Assignees
Labels
feat: view transitionsRelated to the View Transitions feature (scope)Related to the View Transitions feature (scope)