Update Exception Handling for ClusterTasks (#490)

Author: lbwexler

CHANGELOG.md

@@ -29,6 +29,10 @@ for more information.
 
 * Enhance exception handling in `JSONClient` to capture messages returned as raw strings.
 
+### 🐞 Bug Fixes
+
+* Improve exception handling in admin client for sibling instances during startup.
+
 ## 33.2.0 - 2025-11-10
 
 ### 🎁 New Features

grails-app/controllers/io/xh/hoist/admin/ClientAdminController.groovy

@@ -22,7 +22,7 @@ class ClientAdminController extends BaseController {
     def allClients() {
         // Need to serialize the complex WebSocketsSessions as JSON -- parse and rejoin here
         def ret = runOnAllInstancesAsJson(webSocketService.&getAllChannels)
-            .collectMany { it.value.value ? parseArray(it.value.value) : null}
+            .collectMany { it.value.exception ? [] : parseArray(it.value.value)}
         renderJSON(ret)
     }
 

grails-app/services/io/xh/hoist/admin/ClusterObjectsService.groovy

@@ -32,7 +32,7 @@ class ClusterObjectsService extends BaseService {
     ClusterObjectsReport getClusterObjectsReport() {
         def startTimestamp = currentTimeMillis(),
             info = runOnAllInstancesAsJson(this.&listClusterObjects)
-                .collectMany { parseArray(it.value.value) }
+                .collectMany { it.value.exception ? [] : parseArray(it.value.value) }
 
         return new ClusterObjectsReport(info, startTimestamp, currentTimeMillis())
     }

grails-app/services/io/xh/hoist/cluster/ClusterAdminService.groovy

@@ -31,20 +31,11 @@ class ClusterAdminService extends BaseService {
     Collection<Map> getAllStats() {
         runOnAllInstances(this.&getAdminStats)
             .collect { name, result ->
-                def ret = [
+                [
                     name   : name,
-                    isReady: false
+                    isReady: false,
+                    *:(result.value ?: [:])
                 ]
-                if (result.value) {
-                    ret << result.value
-                } else {
-                    Utils.handleException(
-                        exception: result.exception,
-                        logTo: this,
-                        logMessage: "Exception getting stats for $name"
-                    )
-                }
-                return ret
             }
     }
 

grails-app/services/io/xh/hoist/cluster/ClusterService.groovy

@@ -203,6 +203,14 @@ class ClusterService extends BaseService implements ApplicationListener<Applicat
             taskExecutor.submitToMember(clusterRequest, getMember(instance)).get()
         } catch (Throwable t) {
             // task catches issue on instance. Catch deeper hz issue here
+            Utils.handleException(
+                exception: t,
+                logTo: this,
+                logMessage: [
+                    'Error transferring task result',
+                    [sourceInstance: instance, svc: c.svc, method: c.method]
+                ]
+            )
             return new ClusterResult(exception: new ClusterTaskException(t))
         }
     }
@@ -220,6 +228,11 @@ class ClusterService extends BaseService implements ApplicationListener<Applicat
                 return [name, f.get()]
             } catch (Throwable t) {
                 // task catches issue on instance. Catch deeper hz issue here
+                Utils.handleException(
+                    exception: t,
+                    logTo: this,
+                    logMessage: ['Error transferring task result', [sourceInstance: name, svc: c.svc, method: c.method]]
+                )
                 return [name, new ClusterResult(exception: new ClusterTaskException(t))]
             }
         }