fix: avoid duplicate disk IO aggregation#13333
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes incorrect “all disks” aggregation in monitoring by avoiding double-counting disk partition I/O that is already included in the parent block device’s counters.
Changes:
- Replace naive “sum everything” disk I/O aggregation with a helper that excludes partition devices when computing the
"all"total. - Reuse the same aggregation logic in both the monitor collector and dashboard “current info” endpoint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| agent/app/service/monitor.go | Replaces in-loop "all" accumulation with sumDiskIOCounters, and adds partition detection via sysfs. |
| agent/app/service/dashboard.go | Uses sumDiskIOCounters for ioOption == "all" to avoid double-counting partitions in current I/O metrics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+700
to
+706
| func isBlockDevicePartition(name string) bool { | ||
| hostSys := os.Getenv("HOST_SYS") | ||
| if hostSys == "" { | ||
| hostSys = "/sys" | ||
| } | ||
| _, err := os.Stat(filepath.Join(hostSys, "class", "block", filepath.Base(name), "partition")) | ||
| return err == nil |
ssongliu
force-pushed
the
fix/disk-io-duplicate-aggregation
branch
from
July 22, 2026 10:54
7fba9ca to
90025f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #13331