AFMReader refactor update - #1385
Draft
ahobbs7 wants to merge 3 commits into
Draft
Conversation
Collaborator
Author
|
Tests currently fail due to the AFMReader updates being in PR state and hence the current pypi release being used instead. The dependencies may want to be updated to installing from the main branch with git (once the PR is merged) or a pypi release may need to be made for AFMReader before merging this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the loading of AFM files to expect an AFMLoad object from AFMReader rather than the previously returned tuple or dict object.
Note: this pull request should not be merged until the pull request for AFMReader has been merged into main.
docs/usage/configuration.mddocs/usage/data_dictionary.mddocs/usage/advanced.mdand new pages it should link to.No new functions or methods so the following or not necessary