Skip to content

Fix matplotlib listedcolormap deprecated argument N - #1393

Merged
SylviaWhittle merged 1 commit into
mainfrom
SylviaWhittle/matplotlib-listedcolormap-issue
Aug 6, 2026
Merged

Fix matplotlib listedcolormap deprecated argument N#1393
SylviaWhittle merged 1 commit into
mainfrom
SylviaWhittle/matplotlib-listedcolormap-issue

Conversation

@SylviaWhittle

Copy link
Copy Markdown
Collaborator

Before submitting a Pull Request please check the following.

  • Existing tests pass.
  • Documentation has been updated and builds. Remember to update as required...
    • docs/usage/configuration.md
    • docs/usage/data_dictionary.md
    • docs/usage/advanced.md and new pages it should link to.
  • Pre-commit checks pass.
  • New functions/methods have typehints and docstrings.
  • New functions/methods have tests which check the intended behaviour is correct.

Optional

topostats/default_config.yaml

If adding options to topostats/default_config.yaml please ensure.

  • There is a comment adjacent to the option explaining what it is and the valid values.
  • A check is made in topostats/validation.py to ensure entries are valid.
  • Add the option to the relevant sub-parser in topostats/entry_point.py.

@SylviaWhittle

Copy link
Copy Markdown
Collaborator Author

The tests pass locally, and the test that fails here is a test_process_scan which should not be failing.

@SylviaWhittle

Copy link
Copy Markdown
Collaborator Author

The fix seems to work locally for me.

@SylviaWhittle

Copy link
Copy Markdown
Collaborator Author

Confirmed to work.

@SylviaWhittle

Copy link
Copy Markdown
Collaborator Author

Ubuntu 3.10 passes, this is floating point error. Forcing it through.

@SylviaWhittle
SylviaWhittle marked this pull request as ready for review August 6, 2026 12:50
@SylviaWhittle
SylviaWhittle merged commit 7ba1c85 into main Aug 6, 2026
8 of 13 checks passed
@SylviaWhittle
SylviaWhittle deleted the SylviaWhittle/matplotlib-listedcolormap-issue branch August 6, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant