This repository was archived by the owner on Dec 18, 2025. It is now read-only.
Conversation
qihqi
approved these changes
Oct 23, 2024
FanhaiLu1
approved these changes
Oct 29, 2024
| def _weighted_sampling(self, logits, rng, temperature): | ||
| return jax.random.categorical(rng, logits / temperature) | ||
|
|
||
| def _nucleus_sampling(self, logits, rng, temperature, nucleus_topp): |
Collaborator
There was a problem hiding this comment.
Should we replace 'nucleus sampling' with 'top-p sampling'? The latter is easier to understand because the name clearly refers the top p.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports sampling from request. When user set sampling_algorithm to '', each request can send the sampler config which contains algorithm, temperature, topk, nucleus to enable different sampling strategy. We don't have a good way to support random user provided sampling function yet due to the limitation of Jit compilation.
There will be a coming PR to enable it from JetStream side for the e2e workflow to work.