Conversation
26a5d3c to
fd94f9f
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
c72c2d2 to
64854e8
Compare
3e2e2da to
9c5d207
Compare
9c5d207 to
ddf0fd7
Compare
ddf0fd7 to
ac53a95
Compare
| uritemplate>=4.2.0 | ||
| urllib3>=2.5.0 | ||
| uvicorn>=0.38.0 | ||
| uvloop>=0.19.0 |
There was a problem hiding this comment.
Hi we usually don't recommend directly editing dependencies under generated_requirements folder. These two txt files are generated from base_requirements as in this guide. You need to edit base requirements, run seed-env to generated a new set of generated requirements.
Your current patch can work temporarily, but if someone else generated new requirement files, your current change will be lost without notice.
There was a problem hiding this comment.
I created b/486268025 to try to figure out the issue, but it looks like when I follow that procedure, we get into a severe dependency hell with cloud-tpu-diagnostics and some other subsequent libraries.
I think for the purposes of my checkin, the only thing strictly needed actually is just that orbax be upgraded to version 0.11.33 or greater. Uvloop comes from Orbax.
ac53a95 to
4ed9a99
Compare
Description
Enable Experimental Colocated Python Checkpointing experience for Pathways on Cloud.
This feature enables using Orbax's Colocated Python Dispatchers as an alternative to Persistence API. It also enables users to save and restore checkpoints using zarr3 and ocdbt tensorstore formats. Currently in the process of performance tuning.
Further integration/unit testing will be done in a future PR once Colocated Python testing is incorporated.
This relies on Orbax version >=0.11.33.
FIXES: b/388583223
Tests
Tested manually across a test matrix at go/colocated-python-checkpointing-in-maxtext. Integration tests will need to be added once building a colocated python sidecar is supported in MaxText (WIP).
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.