Dump activation shardings#3080
Open
charlesli640 wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
|
I think this LGTM although there are a lot of names to review! How did you generate these names? |
4b17fdb to
511be4b
Compare
Collaborator
Author
These names are generated from local <file_name>/<variable_name>. Sometimes it may not correctly reflect the actual model/layer, but it is basically serving as an identifier/key for logging/dumping/comparing purpose. |
8071699 to
486ebfb
Compare
486ebfb to
6035a59
Compare
f00cd55 to
26481ae
Compare
660b637 to
504c66a
Compare
504c66a to
afc474b
Compare
NuojCheng
reviewed
Feb 19, 2026
NuojCheng
reviewed
Feb 19, 2026
NuojCheng
reviewed
Feb 19, 2026
NuojCheng
approved these changes
Feb 19, 2026
Collaborator
NuojCheng
left a comment
There was a problem hiding this comment.
Thanks Charles! Just some minor comments
28056fd to
38d80fe
Compare
Using inspect to get call stacktrace Cmd to generate input_shardings.json files: python -m tests.utils.run_sharding_dump
38d80fe to
d68647a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To dump activation shardings to golden file for further comparison. It can include in unit test in case further code change touches activation shardings. This PR is the initial submission for sharding dump json files.
Output
The output format is readable and comparable by both human and machine. For exampletests
deepseek2-16b/v5p-16/slice_1activation dump as belowChecklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.