Ccso: Split parameter search into sub-functions - #5336
Open
ram-mohan wants to merge 1 commit into
Open
Conversation
ram-mohan
force-pushed
the
refactor_ccso
branch
from
August 29, 2026 20:05
afa27fe to
a250ecd
Compare
- Split per-plane ccso parameter search into focused sub-functions. - Introduce CcsoCtx/CcsoCtxCommon to carry per-plane-search state, replacing long function-argument lists. - Replace raw memset/memcpy with av2_zero_array/av2_copy_array, and narrow several of them from the full CCSO_BAND_NUM/ CCSO_CLASS_STATS_ENTRIES range down to the max_band/ max_edge_interval range actually used by the current search iteration. - corrects two places that used the horizontal filter-unit log2 for a vertical quantity (derive_blk_md(), get_sb_reuse_dist() and ccso_compute_class_err). no stats changed
ram-mohan
force-pushed
the
refactor_ccso
branch
from
August 29, 2026 20:49
a250ecd to
2d11c2e
Compare
ram-mohan
marked this pull request as ready for review
August 31, 2026 05:37
Contributor
Author
|
@yunqingwang1 @urvangjoshi when you get a chance can you please review |
yunqingwang1
reviewed
Sep 1, 2026
| (1 << s->log2_filter_unit_size_x >> (MI_SIZE_LOG2 - ss_x)); | ||
| const int sb_unit_size_y = | ||
| (1 << log2_filter_unit_size >> (MI_SIZE_LOG2 - ss_y)); | ||
| (1 << s->log2_filter_unit_size_y >> (MI_SIZE_LOG2 - ss_y)); |
Contributor
There was a problem hiding this comment.
Is this the fix? Would it potentially change the encoder result (have STATS CHANGE)? Thanks.
Contributor
Author
There was a problem hiding this comment.
@yunqingwang1 , yes this is the typo fix made. This fix is relevant only for subsampling formats with ss_x != ss_y. For 444 and 420 this change is no-op. For 422 this is relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no stats changed