fix(tiff): fix buffer overrun and make better error reporting#5082
Open
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
fix(tiff): fix buffer overrun and make better error reporting#5082lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
Certain CMYK files (maybe only corrupt ones?) hit an edge case that caused us to read the original 4 channels but into space for only the 3 channels we ultimately report back. Fix that logic. Also noticed several spots where we didn't correctly report back error messages for newer versions of libtiff. This was some kind of oversight from long ago. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
force-pushed
the
lg-tiff-cmyk-fix
branch
from
306aa76 to
5b16b8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain CMYK files (maybe only corrupt ones?) hit an edge case that caused us to read the original 4 channels but into space for only the 3 channels we ultimately report back. Fix that logic.
Also noticed several spots where we didn't correctly report back error messages for newer versions of libtiff. This was some kind of oversight from long ago.