feat(ktx): add initial ktx input/output support. #5185
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| # Copyright Contributors to the OpenImageIO project. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # https://github.com/AcademySoftwareFoundation/OpenImageIO | ||
|
|
||
| # TODO: revert this before merging! I set this to my own PR branch that includes | ||
| # BCn and that will be merged (as per the reviewer) | ||
| set_cache (Ktx_BUILD_VERSION add-BCn-decoder "Ktx version for local builds") | ||
| set (Ktx_GIT_REPOSITORY "https://github.com/walcht/KTX-Software.git") | ||
| set_cache (Ktx_GIT_TAG "${Ktx_BUILD_VERSION}" "Git branch or tag") | ||
| set_cache (Ktx_GIT_COMMIT "77075ec1d5125df4b938e2f5d96565b10189b1f3" | ||
| "commit hash to verify tag/branch against") | ||
| set_cache (Ktx_BUILD_SHARED_LIBS OFF #${LOCAL_BUILD_SHARED_LIBS_DEFAULT} | ||
| DOC "Should a local Ktx build, if necessary, build shared libraries" ADVANCED) | ||
|
|
||
| # TODO: if libktx is built as a shared library, astcenc have to be linked-against. | ||
| # I don't know how to 'cleanly' do this in OIIO CMake (yet). | ||
| # Even though all CIs pass, do not merge before addressing this! | ||
|
|
||
| string (MAKE_C_IDENTIFIER ${Ktx_BUILD_VERSION} Ktx_VERSION_IDENT) | ||
|
|
||
| # Override C/C++ compiler (useful when running CI with unsupported Intel's compiler ICX) | ||
| set_cache (KTX_CMAKE_C_COMPILER ${CMAKE_C_COMPILER} "libktx build C compiler override" ADVANCED) | ||
| set_cache (KTX_CMAKE_CXX_COMPILER ${CMAKE_CXX_COMPILER} "libktx build C++ compiler override" ADVANCED) | ||
|
|
||
| # The only tested libktx versions are: | ||
| # - v0.0.0 (main:HEAD which is versionless) | ||
| # - v5.0.0-rc1 (newest supported) | ||
| # | ||
| # for detailed build instructions, see: | ||
| # https://github.com/KhronosGroup/KTX-Software/blob/main/BUILDING.md | ||
| # | ||
| # KTX-Software not only provides Ktx but also a set of CLI tools and load | ||
| # test applications that we do not need. We only need the libktx component | ||
| # without any GPU texture loading functionalities. | ||
| # | ||
| # On x86_64, libktx defaults to using AVX2 for ASTC. For Intel-based MacOS, the | ||
| # default AVX2 requires x86_64h which may not be available (e.g., Intel-based | ||
| # MacOS Github Actions CIs). For ARM64 libktx defaults to using Neon. For | ||
| # 'unknown' CPUs, SIMD is disabled (see KTX-Software/lib/CMakeLists.txt for details). | ||
| # | ||
| # Possible values: | ||
| # - "": default, let libktx decide | ||
| # - ASTCENC_ISA_NATIVE: native SIMD | ||
| # - ASTCENC_ISA_NONE: disable SIMD | ||
| # - ASTCENC_ISA_SVE_256: slowest on Arm | ||
| # - ASTCENC_ISA_SVE_128: 2nd fastest on Arm | ||
| # - ASTCENC_ISA_NEON: fasted on Arm | ||
| # - ASTCENC_ISA_AVX2: fastest on x86_64 (may not be supported on Intel-based MacOS runners) | ||
| # - ASTCENC_ISA_SSE41: 2nd fastest on x86_64 (guaranteed to be supported) | ||
| # - ASTCENC_ISA_SSE2: slowest on x86_64 (guaranteed to be supported) | ||
| # | ||
| set_cache (Ktx_ASTCENC_ISA "" "ASTC specific SIMD instruction set. See astc-encoder/CMakeLists.txt for more details" ADVANCED) | ||
|
|
||
| set(CMAKE_ARGS_LIST | ||
| -DCMAKE_POSITION_INDEPENDENT_CODE=ON | ||
| -DCMAKE_C_COMPILER=${KTX_CMAKE_C_COMPILER} | ||
| -DCMAKE_CXX_COMPILER=${KTX_CMAKE_CXX_COMPILER} | ||
| -DBUILD_SHARED_LIBS=${Ktx_BUILD_SHARED_LIBS} | ||
| -DCMAKE_INSTALL_LIBDIR=lib | ||
| -DLIBKTX_VERSION_READ_ONLY=OFF | ||
| -DLIBKTX_VERSION_FULL=ON | ||
| -DLIBKTX_FEATURE_KTX1=ON # Setting this to OFF causes linker issues | ||
| -DLIBKTX_FEATURE_KTX2=ON | ||
| -DLIBKTX_FEATURE_VK_UPLOAD=OFF | ||
| -DLIBKTX_FEATURE_GL_UPLOAD=OFF | ||
| -DLIBKTX_FEATURE_ETC_UNPACK=OFF # This has some weird licensing and I don't feel comfortable including it ... | ||
| ) | ||
|
|
||
| if(Ktx_ASTCENC_ISA) | ||
| list(APPEND CMAKE_ARGS_LIST -D${Ktx_ASTCENC_ISA}=ON) | ||
| endif() | ||
|
|
||
| build_dependency_with_cmake(Ktx | ||
| VERSION ${Ktx_BUILD_VERSION} | ||
| GIT_REPOSITORY ${Ktx_GIT_REPOSITORY} | ||
| GIT_TAG ${Ktx_GIT_TAG} | ||
| GIT_COMMIT ${Ktx_GIT_COMMIT} | ||
| SOURCE_SUBDIR lib # To only build Ktx, cmake has to point to: KTX-Software/lib | ||
| CMAKE_ARGS ${CMAKE_ARGS_LIST} | ||
| ) | ||
|
|
||
| # Set some things up that we'll need for a subsequent find_package to work | ||
| set (Ktx_ROOT ${Ktx_LOCAL_INSTALL_DIR}) | ||
|
|
||
| # Signal to caller that we need to find again at the installed location | ||
| set (Ktx_REFIND TRUE) | ||
| set (Ktx_REFIND_ARGS CONFIG) | ||
|
|
||
| if (Ktx_BUILD_SHARED_LIBS) | ||
| install_local_dependency_libs (Ktx ktx) # notice libname is lowercase | ||
| endif () |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a separate PR #5394 that will raise the cmake minimum for OIIO 3.2 to cmake 3.22. So I think you can remove this bit of complexity.