fix(jpegxl): harden against corrupt input - #5378
Merged
Merged
Conversation
- Overflow protection for the out-buffer-size sanity check, which computed xsize*ysize*channels*bits/8 as uint32 previously. - The result of m_io->read() was captured but never checked; a short read left the tail of the input buffer uninitialized and handed it to libjxl. Error out when the read is short. - If the decode loop reached JXL_DEC_SUCCESS with basic info but never requested an image-out buffer, m_buffer stayed null while open() returned success, so a later read_native_scanline() dereferenced null. Reject such files at open time. - Add a truncated-codestream test for jxl. Assisted-by: Claude Code / Claude Opus 4.8 Signed-off-by: Larry Gritz <lg@larrygritz.com>
brechtvl
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Claude Code / Claude Opus 4.8