feat: SG-41979: Add hotkey and env var for no sequence formation during drag and drop#1139
Merged
chenlj1 merged 6 commits intoAcademySoftwareFoundation:mainfrom Mar 5, 2026
Merged
Conversation
bernie-laberge
approved these changes
Feb 18, 2026
Contributor
bernie-laberge
left a comment
There was a problem hiding this comment.
LGTM
Thank you @chenlj1 !
eloisebrosseau
approved these changes
Mar 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds user-controlled ways to prevent sequence formation when loading images—either interactively during drag-and-drop (Alt/Option) or globally via an environment-variable regex—so files can be loaded as individual sources instead of being contracted into sequences.
Changes:
- Add Alt/Option handling to drag-and-drop so dropped file lists bypass sequence contraction.
- Propagate a
"drop-no-sequence"tag through the Mu layer intoRvSessionloading paths to avoid regrouping. - Add
RV_NO_SEQUENCE_PATTERNsupport insequencesInFileList()to skip grouping for matching filenames.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/lib/base/TwkUtil/FrameUtils.cpp | Adds regex-based “do not sequence” filtering during sequence detection. |
| src/lib/app/mu_rvui/rvui.mu | Captures Alt modifier at drop time and forwards a tag to addSources. |
| src/lib/app/mu_rvui/rvtypes.mu | Extends UI State with ddNoSequence flag. |
| src/lib/app/RvCommon/QTTranslator.cpp | Uses Alt modifier to bypass sequence contraction and forwards modifiers into drag-drop events. |
| src/lib/app/RvApp/RvSession.cpp | Treats "drop-no-sequence" tag as a no-sequencing request in both delayed and immediate load paths. |
bernie-laberge
approved these changes
Mar 2, 2026
eloisebrosseau
approved these changes
Mar 4, 2026
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
cedrik-fuoco-adsk
approved these changes
Mar 5, 2026
45417a5
into
AcademySoftwareFoundation:main
25 of 26 checks passed
bernie-laberge
pushed a commit
to bernie-laberge/OpenRV
that referenced
this pull request
Mar 5, 2026
…ng drag and drop (AcademySoftwareFoundation#1139) alt/option hotkey and env var with a pattern to prevent RV from loading images as an image sequence** Added an Alt/Option hotkey for drag-and-drop: holding Alt while dropping files prevents sequence formation so each file is added as its own source. Modifier is read in QTTranslator, the Mu layer passes a "drop-no-sequence" tag into addSources, RvSession uses that tag so LoadState and the non-delayed path do not re-group. Added RV_NO_SEQUENCE_PATTERN that can be set using export RV_NO_SEQUENCE_PATTERN="wanted_pattern". When set to a regex, matching file names are not grouped into sequences. The previous env substring (RV_NO_SEQUENCE_SUBSTRING) did not meet the client’s needs. They wanted a hotkey so they can have more control over sequence formation. The client wanted something more powerful than the previous substring approach and suggested using RegEx instead. The hotkey was tested on macOS by holding down the Option key and verifying that no sequence would form during a drag and drop of files. https://github.com/user-attachments/assets/edb60953-b6b6-4a65-a687-e2d4357600ef The RegEx was tested on macOS by setting the environment variable by using export RV_NO_SEQUENCE_PATTERN="_[vV][0-9]+\.jpg$" https://github.com/user-attachments/assets/c81ecac9-82c0-453d-8931-e068e36d3ed6 --------- Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
bernie-laberge
pushed a commit
to bernie-laberge/OpenRV
that referenced
this pull request
Mar 5, 2026
…ng drag and drop (AcademySoftwareFoundation#1139) alt/option hotkey and env var with a pattern to prevent RV from loading images as an image sequence** Added an Alt/Option hotkey for drag-and-drop: holding Alt while dropping files prevents sequence formation so each file is added as its own source. Modifier is read in QTTranslator, the Mu layer passes a "drop-no-sequence" tag into addSources, RvSession uses that tag so LoadState and the non-delayed path do not re-group. Added RV_NO_SEQUENCE_PATTERN that can be set using export RV_NO_SEQUENCE_PATTERN="wanted_pattern". When set to a regex, matching file names are not grouped into sequences. The previous env substring (RV_NO_SEQUENCE_SUBSTRING) did not meet the client’s needs. They wanted a hotkey so they can have more control over sequence formation. The client wanted something more powerful than the previous substring approach and suggested using RegEx instead. The hotkey was tested on macOS by holding down the Option key and verifying that no sequence would form during a drag and drop of files. https://github.com/user-attachments/assets/edb60953-b6b6-4a65-a687-e2d4357600ef The RegEx was tested on macOS by setting the environment variable by using export RV_NO_SEQUENCE_PATTERN="_[vV][0-9]+\.jpg$" https://github.com/user-attachments/assets/c81ecac9-82c0-453d-8931-e068e36d3ed6 --------- Signed-off-by: chenl1 <ling.jie.chen@autodesk.com> Signed-off-by: Bernard Laberge <bernard.laberge@autodesk.com>
bernie-laberge
pushed a commit
to bernie-laberge/OpenRV
that referenced
this pull request
Mar 6, 2026
…ng drag and drop (AcademySoftwareFoundation#1139) alt/option hotkey and env var with a pattern to prevent RV from loading images as an image sequence** Added an Alt/Option hotkey for drag-and-drop: holding Alt while dropping files prevents sequence formation so each file is added as its own source. Modifier is read in QTTranslator, the Mu layer passes a "drop-no-sequence" tag into addSources, RvSession uses that tag so LoadState and the non-delayed path do not re-group. Added RV_NO_SEQUENCE_PATTERN that can be set using export RV_NO_SEQUENCE_PATTERN="wanted_pattern". When set to a regex, matching file names are not grouped into sequences. The previous env substring (RV_NO_SEQUENCE_SUBSTRING) did not meet the client’s needs. They wanted a hotkey so they can have more control over sequence formation. The client wanted something more powerful than the previous substring approach and suggested using RegEx instead. The hotkey was tested on macOS by holding down the Option key and verifying that no sequence would form during a drag and drop of files. https://github.com/user-attachments/assets/edb60953-b6b6-4a65-a687-e2d4357600ef The RegEx was tested on macOS by setting the environment variable by using export RV_NO_SEQUENCE_PATTERN="_[vV][0-9]+\.jpg$" https://github.com/user-attachments/assets/c81ecac9-82c0-453d-8931-e068e36d3ed6 --------- Signed-off-by: chenl1 <ling.jie.chen@autodesk.com> Signed-off-by: Bernard Laberge <bernard.laberge@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SG-41979: [RV] Add alt/option hotkey and env var with a pattern to prevent RV from loading images as an image sequence
Summarize your change.
Added an Alt/Option hotkey for drag-and-drop: holding Alt while dropping files prevents sequence formation so each file is added as its own source. Modifier is read in QTTranslator, the Mu layer passes a "drop-no-sequence" tag into addSources, RvSession uses that tag so LoadState and the non-delayed path do not re-group.
Added RV_NO_SEQUENCE_PATTERN that can be set using export RV_NO_SEQUENCE_PATTERN="wanted_pattern". When set to a regex, matching file names are not grouped into sequences.
Describe the reason for the change.
The previous env substring (RV_NO_SEQUENCE_SUBSTRING) did not meet the client’s needs. They wanted a hotkey so they can have more control over sequence formation.
The client wanted something more powerful than the previous substring approach and suggested using RegEx instead.
Describe what you have tested and on which operating system.
The hotkey was tested on macOS by holding down the Option key and verifying that no sequence would form during a drag and drop of files.
Untitled.mov
The RegEx was tested on macOS by setting the environment variable by using export RV_NO_SEQUENCE_PATTERN="_[vV][0-9]+.jpg$"
Screen.Recording.2026-02-23.at.10.27.48.AM.mov