feat(files): skip excluded paths during copy operations - #2555
Merged
Conversation
Contributor
Greptile SummaryAdds configurable exclusion filtering to copy-and-paste operations.
Confidence Score: 5/5The PR appears safe to merge. The previously reported destination-deletion issue is fixed because copyEntry now returns for an excluded source before invoking the callback that can delete a conflicting destination, and focused coverage verifies that the callback is not called. Important Files Changed
Sequence DiagramsequenceDiagram
participant Paste as Paste handler
participant Copy as copyEntry
participant Match as Exclusion matcher
participant FS as fsOperation
Paste->>Copy: Copy source into target directory
Copy->>Match: Check source URL against patterns
alt Source is excluded
Match-->>Copy: Match
Copy-->>Paste: skipped result
else Source is included
Match-->>Copy: No match
Copy->>Paste: Run top-level pre-copy checks
Paste-->>Copy: Continue
Copy->>FS: Create file or directory
loop Directory children
Copy->>Copy: Recursively copy child
end
Copy-->>Paste: copied and skipped counts
end
Reviews (2): Last reviewed commit: "fix the conflict case" | Re-trigger Greptile |
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.