fix(harness): limit opencode concurrency with global semaphore (#438)#505
Merged
AbirAbbas merged 6 commits intoAgent-Field:mainfrom May 1, 2026
Merged
Conversation
|
|
Contributor
Author
|
If there are any issues or improvements needed, please let me know—I’ll fix them. |
AbirAbbas
reviewed
Apr 28, 2026
Contributor
Author
|
if you have a time review and tell me if there is any changes to be made. |
Contributor
Author
|
hey guys if you check this pr and able to merge it then i can work on this issue (#404). |
Contributor
taking a look! |
The release tooling auto-generates CHANGELOG.md entries on each chore(release) commit; manual edits collide with that and produced a duplicate [0.1.72-rc.6] heading here. Reverting CHANGELOG.md to its pre-edit state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The existing semaphore tests mock `p.runCLI`, which proves the channel arithmetic but not that the semaphore actually serializes real subprocess spawns alongside the new opencode 1.14+ flag construction (Agent-Field#519). Adds two functional tests that drive the full Execute path through RunCLI: - TestOpenCodeConcurrencyLimit_RealSubprocess: a fake `opencode` shell script writes per-invocation start/end timestamps; a sweep-line over the recorded spans asserts the maximum overlap never exceeds OPENCODE_MAX_CONCURRENT (and, conversely, that real overlap was observed — guarding against a future change that accidentally serializes everything to 1). - TestOpenCodeSemaphore_ReleasedOnSubprocessFailure: with limit=1, three sequential calls into a script that exits non-zero must all complete. If a slot leaked on the failure path the second call would block forever. Manually smoke-tested against a real opencode 1.14.29 binary as well: 4 concurrent Execute calls with limit=2 produced the expected ~2x single-call duration (paired stair pattern), and the binary accepted the new `run --dir <project> -m <model> --dangerously-skip-permissions <prompt>` invocation without help-screen fallback. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Performance
✓ No regressions detected |
Contributor
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
Contributor
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
AbirAbbas
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a concurrency limit to OpenCodeProvider.Execute to prevent unbounded subprocess spawning under parallel workloads.
Changes
Motivation
Previously, each Execute() call spawned a subprocess without any limit, causing:
This change introduces backpressure and stabilizes execution.
Notes
Testing
./scripts/test-all.shAdditional verification (please describe):
Added concurrency test ensuring at most N executions run simultaneously
Added context cancellation test to ensure blocked callers exit immediately
Checklist
CHANGELOG.md(or this change does not warrant a changelog entry).Screenshots (if UI-related)
Related issues