fix(web): ship public/ assets in the published ao-web package#2159
Open
GouravSingal-code wants to merge 1 commit into
Open
fix(web): ship public/ assets in the published ao-web package#2159GouravSingal-code wants to merge 1 commit into
GouravSingal-code wants to merge 1 commit into
Conversation
`packages/web/public/` is committed but missing from the package.json `files` allowlist, so assets such as `public/mascot.png` are stripped from the published `@aoagents/ao-web` tarball. The dashboard then logs `The requested resource isn't a valid image for /mascot.png` and the AppMark brand mark renders as a broken image. Add `"public"` to the `files` array so the static assets (mascot.png, offline.html, sw.js) are included in the published package. Closes AgentWrapper#2123 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
GouravSingal-code
force-pushed
the
fix/2123-ship-web-public-assets
branch
from
d03b56a to
575925f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2123
Problem
packages/web/public/is committed in source, butpublic/is missing from thefilesallowlist inpackages/web/package.json. As a result, npm stripspublic/from the published@aoagents/ao-webtarball, sopublic/mascot.png(and other public assets) never ship. At runtime the dashboard logs:and the
AppMarkbrand mark renders as a broken image.Fix
Add
"public"to thefilesarray so the committed static assets are included in the published package.Verification
npm pack --dry-runinpackages/webbefore the change does not list anypublic/files; after the change it includes them:No code/runtime changes — packaging metadata only.