feat(api): prefer x-agenta-flags for evaluation chat detection #3623
+107
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Parse x-agenta-flags.is_chat from OpenAPI operations when available - Fall back to legacy heuristic based on messages fields - Thread is_chat into evaluation payload building and add temporary logs
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The SDK (PR #3622) changed the OpenAPI vendor extension from a flat 'x-agenta-flags' key to a nested 'x-agenta: {flags: {...}}' structure. Update _get_openapi_chat_flag to read from the new nested path. Also removes unused imports (common, make_hash_id) caught by ruff.
mmabrouk
force-pushed
the
feat/chat-interface-eval-detection
branch
from
8ef59cf to
a7478cd
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
mmabrouk
commented
Feb 9, 2026
…llback, restore removed variables
- Fix TODO comment: says 'messages' column, not 'chats'
- Remove datapoint.get('chat') fallback — 'chat' was the old column name,
the FE now uses 'messages'. No need for backward compat.
- Restore references/links variables + imports that were removed by ruff
as unused — they belong to a commented-out make_hash_id call and are
out of scope for this PR.
dosubot
bot
added
the
size:L
…SaveTestsetModal SaveTestsetModal.tsx hardcodes 'chat' as the column name when re-saving evaluation results to a testset. Several FE readers (DebugSection, CHAT_ARRAY_KEYS, legacy evaluation exports) also reference 'chat'. Keep the fallback: prefer 'messages', fall back to 'chat'.
Member
Author
Testing ResultsWhat was tested
What's confirmed working
Additional tests needed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #3622
Updates evaluation OpenAPI parsing to prefer the new
x-agenta-flags.is_chatvendor extension, with fallback to legacy heuristics.Changes
x-agenta-flags.is_chatfrom OpenAPI/testor/runoperationsmessagesproperty orx-parameter: messages)is_chatthrough payload construction so message parsing only runs for chat appsLogging (temporary)
or
These logs will be removed after validation.
Files Changed
api/oss/src/services/llm_apps_service.pyapi/oss/src/core/evaluations/tasks/legacy.pydocs/design/chat-interface-rfc/status.md