-
Notifications
You must be signed in to change notification settings - Fork 478
feat(frontend): add cloud region selector on sign-in #3629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@jp-agenta we need to set these Runtime env (secrets/vars): AGENTA_CLOUD_REGION=eu|us (and probably in staging or so for testing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| pageExtensions: ["ts", "tsx", "js", "jsx"], | ||
| productionBrowserSourceMaps: true, | ||
| outputFileTracingRoot: path.resolve(__dirname, ".."), | ||
| transpilePackages, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Refers to lines 12-31)
🚩 transpilePackages now applies in development mode too
The transpilePackages array was previously only applied in production (!isDevelopment). Now it's moved to the common config at next.config.ts:31 and includes @agenta/oss. This means these packages are transpiled in both development (with Turbopack) and production builds. This is likely intentional to support the workspace package, but it's a behavior change worth noting for the reviewer.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ardaerzin I think this was changed due to some local issue compiling. It should be reverted right>
However, in this PR, plenty of things seem to be hardcoded:
I'd say that adding an env var for the region only is not clean. Either we put everything in env vars or nothing. In this case, I'd
I guess the former is simpler. Now, in self-hosted, all this would still be visible ? Even the decision to show this whole thing or not follows the same rule:
|
Summary
Config
AGENTA_CLOUD_REGION=eu|us(injected intoNEXT_PUBLIC_AGENTA_CLOUD_REGIONviaweb/entrypoint.sh)AGENTA_WEB_URL(setsNEXT_PUBLIC_AGENTA_WEB_URL),AGENTA_API_URL