Skip to content

Conversation

@singiamtel
Copy link
Contributor

@singiamtel singiamtel commented Jan 27, 2026

Heavily speeds up compilation

CC @ktf

@github-actions github-actions bot added the pwgje label Jan 27, 2026
@github-actions github-actions bot changed the title Add PCH for JET tasks [PWGJE] Add PCH for JET tasks Jan 27, 2026
@github-actions
Copy link

github-actions bot commented Jan 27, 2026

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

Heavily speeds up compilation
@fjonasALICE
Copy link
Collaborator

what is the time difference in compilation that you observe? should we consider this for other JE tasks too? also, are there some other headers that do not frequently change in O2Physics that we should consider precompiling?

@ktf
Copy link
Member

ktf commented Jan 28, 2026

@singiamtel very nice. Could you share numbers on the improvement? How does it handle changes in the framework headers? Will it actually notice and recompile? That's where the previous attempt I had did not converge.

@aalkin
Copy link
Member

aalkin commented Jan 28, 2026

This is great, together with my changes at the framework level this will reduce the compilation times very significantly. However, I suggest restructuring this to make it more transparent for the end users, we do not want to rewrite every CMakeLists.txt in O2Physics. We can introduce a convention on the "central" target for each PWG, that collects all the universal headers and then update o2physics_add_dpl_workflow to automatically use it.

@ktf
Copy link
Member

ktf commented Jan 28, 2026

@vkucera on a separate note, could we please make sure the O2 linter does not tell people to change QA to Qa ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants