Skip to content

[PWGJE] Use Precompiled headers for Jet Substructure tasks #14690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ktf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[PWGJE] Use Precompiled headers for Jet Substructure tasks #14690

ktf wants to merge 1 commit into from
+38 −2

Conversation

@ktf
Copy link
Member

@ktf ktf commented Jan 29, 2026

No description provided.

@github-actions github-actions bot added the pwgje label Jan 29, 2026
@github-actions github-actions bot changed the title Use Precompiled headers for Jet Substructure tasks [PWGJE] Use Precompiled headers for Jet Substructure tasks Jan 29, 2026
@ktf
Copy link
Member Author

ktf commented Jan 29, 2026

@singiamtel @aalkin as discussed offline this is my suggestion for #14655.

@alibuild
Copy link
Collaborator

alibuild commented Jan 29, 2026

Error while checking build/O2Physics/o2 for 0ae8181 at 2026-01-29 13:51:

## sw/BUILD/O2Physics-latest/log
CMake Error at PWGJE/Tasks/CMakeLists.txt:11 (add_library):
CMake Error in PWGJE/Tasks/CMakeLists.txt:
CMake Error at PWGJE/Tasks/CMakeLists.txt:11 (add_library):

Full log here.

@nzardosh
Copy link
Collaborator

nzardosh commented Feb 1, 2026

Hi @ktf you could also add the jetSubstructureHFOutput tasks as well since they are heavily templated. Then there are the tasks in the jet finder and matching folders too

@ktf ktf force-pushed the precompile-example branch from 0ae8181 to 9245ea0 Compare February 1, 2026 08:50
@ktf
Copy link
Member Author

ktf commented Feb 1, 2026

Yes, I will do that in a separate PR, though. First we should all agree on the approach next Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@nzardosh nzardosh Awaiting requested review from nzardosh nzardosh is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ktf @alibuild @nzardosh