Skip to content

[PWGUD] Add ptSpectraInclusiveUpc.cxx#16386

Open
ariffero wants to merge 15 commits into
AliceO2Group:masterfrom
ariffero:dev-dca
Open

[PWGUD] Add ptSpectraInclusiveUpc.cxx#16386
ariffero wants to merge 15 commits into
AliceO2Group:masterfrom
ariffero:dev-dca

Conversation

@ariffero
Copy link
Copy Markdown
Contributor

Add task to produce pT spectra and DCA_xy distributions of pion, kaon and protons in inclusive photonuclear events.

@github-actions github-actions Bot added the pwgud label May 26, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2026

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add ptSpectraInclusiveUpc.cxx [PWGUD] Add ptSpectraInclusiveUpc.cxx May 26, 2026
@ariffero ariffero marked this pull request as ready for review May 26, 2026 09:52
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 0b4f2cf at 2026-05-26 11:59:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:126:56: error: unused parameter 'mcCollision' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:164:30: error: unused parameter 'collision' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:164:86: error: unused parameter 'mcParticles' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:342:10: error: unused variable 'nSigmaPiTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:343:10: error: unused variable 'nSigmaKaTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:344:10: error: unused variable 'nSigmaPrTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:331:30: error: unused parameter 'collision' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 0b4f2cf at 2026-05-26 12:11:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:126:56: error: unused parameter 'mcCollision' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:164:30: error: unused parameter 'collision' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:164:86: error: unused parameter 'mcParticles' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:342:10: error: unused variable 'nSigmaPiTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:343:10: error: unused variable 'nSigmaKaTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:344:10: error: unused variable 'nSigmaPrTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/ptSpectraInclusiveUpc.cxx:331:30: error: unused parameter 'collision' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

Comment thread PWGUD/Tasks/ptSpectraInclusiveUpc.cxx Outdated
Comment thread PWGUD/Tasks/ptSpectraInclusiveUpc.cxx Outdated
Comment thread PWGUD/Tasks/ptSpectraInclusiveUpc.cxx Outdated
Comment thread PWGUD/Tasks/ptSpectraInclusiveUpc.cxx Outdated
Comment thread PWGUD/Tasks/ptSpectraInclusiveUpc.cxx Outdated
@vkucera vkucera marked this pull request as draft May 26, 2026 12:32
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 26, 2026

You are supposed to make sure your code compiles without warnings before you open a PR.

Comment thread PWGUD/Tasks/ptSpectraInclusiveUpc.cxx Outdated
Comment thread PWGUD/Tasks/ptSpectraInclusiveUpc.cxx Outdated
Comment thread PWGUD/Tasks/ptSpectraInclusiveUpc.cxx Outdated
ariffero added 3 commits May 27, 2026 09:51
Remove unused iterators and improve clarity of processSim subscription
Please consider the following formatting changes to AliceO2Group#16386
@ariffero
Copy link
Copy Markdown
Contributor Author

You are supposed to make sure your code compiles without warnings before you open a PR.

Sure, sorry for that. The build went fine on my local machine, but then it did not pass the build test here. Is there an easy way to check locally that it will pass the test here? Or should I just wait for the test to finish?
Thanks a lot in advance!
Andrea

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 27, 2026

You are supposed to make sure your code compiles without warnings before you open a PR.

Sure, sorry for that. The build went fine on my local machine, but then it did not pass the build test here. Is there an easy way to check locally that it will pass the test here? Or should I just wait for the test to finish? Thanks a lot in advance! Andrea

Hi Andrea, the CI build is the same as your local build, so locally you should get the same warnings in the log as here. The difference is that locally the warnings do not make the compilation fail. You are supposed to verify that your log does not contain any compilation warnings. It is part of the contribution instructions.

@ariffero ariffero marked this pull request as ready for review May 27, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants