Skip to content

Add --configmaps-secret option to the operator#1394

Open
frankwg wants to merge 1 commit intoAltinity:0.24.0from
frankwg:configmap-secret-request-option
Open

Add --configmaps-secret option to the operator#1394
frankwg wants to merge 1 commit intoAltinity:0.24.0from
frankwg:configmap-secret-request-option

Conversation

@frankwg
Copy link
Contributor

@frankwg frankwg commented Apr 12, 2024

This PR makes OLM based deployment can also use configmaps and secret to host those configurations.


Thanks for taking the time to contribute to clickhouse-operator!

Please, read carefully instructions on how to make a Pull Request.

This will help a lot for maintainers to adopt your Pull Request.

Important items to consider before making a Pull Request

Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

--

1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

@alex-zaitsev alex-zaitsev changed the base branch from 0.23.5 to 0.24.0 April 24, 2024 17:51
@sunsingerus
Copy link
Collaborator

Thank you @frankwg for this contribution. The use case is valid — OLM/OCP deployments need a way to bootstrap the operator's ConfigMaps and Secret before the main container starts, and the initContainer approach is a reasonable pattern for that.

However, we are putting this PR on hold for now for the following reasons:

  1. Stale / merge conflicts. The PR targets 0.24.0 (April 2024) and currently has merge conflicts. The codebase has changed substantially since then and the PR would need a full rebase before we can review it properly.

  2. Hardcoded default credentials. HandleSecretCreation creates the clickhouse-operator Secret with the default password hardcoded in the source. We'd want a cleaner approach here — either deriving the value from an existing config source or making it configurable.

  3. Error handling. getConfigsFrom() calls log.Fatal on read errors, which terminates the process without a meaningful exit code path. Errors should be propagated up and handled by the caller.

We'd welcome a rebased version of this PR against the current master branch with the above points addressed. In the meantime we'll keep this open for tracking.

@sunsingerus sunsingerus added enhancement New feature or request waiting reply Altinity is waiting for a reply research required This issue requires additional research hold This issue has been put on hold labels Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request hold This issue has been put on hold research required This issue requires additional research waiting reply Altinity is waiting for a reply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants