fix: make SafeAreaView respect edges param on web#685
Open
klxiaoniu wants to merge 1 commit intoAppAndFlow:mainfrom
Open
fix: make SafeAreaView respect edges param on web#685klxiaoniu wants to merge 1 commit intoAppAndFlow:mainfrom
SafeAreaView respect edges param on web#685klxiaoniu wants to merge 1 commit intoAppAndFlow:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the web implementation of SafeAreaView where the edges parameter was not being respected correctly. When specific edges were provided (e.g., edges={['bottom']}), all edges were still receiving insets instead of only the specified ones.
Changes:
- Reordered the switch cases in
getEdgeValuefunction to makeundefinededge modes default to 'off' behavior (no inset) instead of 'additive' behavior (applying inset)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The following code works fine on Android and iOS, but on Web the padding will be set to all edges despite what we set. When
getEdgeValueis called with the third valueundefined, which means the inset is not required, it will apply inset incorrectly.Test Plan
Use the latest code to run on web to se if edges are applied properly.