chore: update Python version requirements to 3.12#4963
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - 我在这里给出了一些整体层面的反馈:
- 将
requires-python从>=3.10改为>=3.12,会对使用 3.10/3.11 的用户造成破坏性变更;请确认这是有意为之,并且项目确实不再打算支持这些版本。 - 随着在
dependencies中新增python-socks>=2.8.0,建议检查在 Dockerfile 中是否仍然需要单独显式安装socksio,或者现在这两个库之间是否存在功能重叠和冗余。
供 AI Agent 使用的提示
Please address the comments from this code review:
## Overall Comments
- Changing `requires-python` from `>=3.10` to `>=3.12` is a breaking change for users on 3.10/3.11; please confirm this is intentional and that the project no longer aims to support those versions.
- With the addition of `python-socks>=2.8.0` to `dependencies`, consider verifying whether `socksio` is still needed as a separate explicit install in the Dockerfile or if there is now redundancy between these libraries.帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English
Hey - I've left some high level feedback:
- Changing
requires-pythonfrom>=3.10to>=3.12is a breaking change for users on 3.10/3.11; please confirm this is intentional and that the project no longer aims to support those versions. - With the addition of
python-socks>=2.8.0todependencies, consider verifying whethersocksiois still needed as a separate explicit install in the Dockerfile or if there is now redundancy between these libraries.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Changing `requires-python` from `>=3.10` to `>=3.12` is a breaking change for users on 3.10/3.11; please confirm this is intentional and that the project no longer aims to support those versions.
- With the addition of `python-socks>=2.8.0` to `dependencies`, consider verifying whether `socksio` is still needed as a separate explicit install in the Dockerfile or if there is now redundancy between these libraries.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
改为3.12的话,openai-whisper就没法用了。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications / 改动点
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
requirements.txt和pyproject.toml文件相应位置。/ I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations inrequirements.txtandpyproject.toml.由 Sourcery 提供的摘要
将项目的最低和运行时 Python 版本在容器和打包元数据中统一提升到 3.12。
新特性:
python-socks。增强改进:
pyproject.toml中的requires-python约束从>=3.10收紧为>=3.12,以反映新的受支持运行时基线。构建:
python:3.12-slim,并相应调整.python-version。Original summary in English
Summary by Sourcery
Raise the project’s minimum and runtime Python version to 3.12 across container and packaging metadata.
New Features:
Enhancements:
Build: