feat: add delete button to persona management dialog #4978
Merged
+36
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The persona management dialog had no way to delete personas from the edit view. Users had to close the dialog and use the card menu.
Changes
v-if="editingPersona")deletePersona()method with confirmation dialog and API call to/api/persona/deletedeletedevent emitterhandlePersonaDeleted()event handler to refresh persona listImplementation
The delete button only appears when editing existing personas, not when creating new ones. Uses existing i18n translations and API endpoints. State management uses
finallyblock to ensure cleanup on both success and error paths.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.soulter.top/home/REDACTED/work/AstrBot/AstrBot/.venv/bin/python3 /home/REDACTED/work/AstrBot/AstrBot/.venv/bin/python3 main.py(dns block)astrbot-registry.soulter.top/home/REDACTED/work/AstrBot/AstrBot/.venv/bin/python3 /home/REDACTED/work/AstrBot/AstrBot/.venv/bin/python3 main.py(dns block)models.dev/home/REDACTED/work/AstrBot/AstrBot/.venv/bin/python3 /home/REDACTED/work/AstrBot/AstrBot/.venv/bin/python3 main.py(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.