Include unlisted tracks in playlist responses#755
Merged
rickyrombo merged 2 commits intomainfrom Apr 8, 2026
Merged
Conversation
Unlisted tracks added to playlists were being filtered out by the get_tracks query, causing a mismatch between playlist_contents and the hydrated tracks array. This sets IncludeUnlisted=true for both GET /v1/playlists/:id and GET /v1/playlists/:id/tracks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates playlist track hydration so unlisted tracks included in a playlist are also included in the API’s hydrated tracks arrays, eliminating mismatches between playlist_contents and tracks.
Changes:
- Include unlisted tracks when hydrating
GET /v1/playlists/:id/tracks. - Include unlisted tracks when hydrating playlists via
dbv1.PlaylistsKeyed(affectsGET /v1/playlists/:idand any other playlist responses that hydrate tracks via this path). - Add
IncludeUnlistedtodbv1.ParallelParamsand plumb it through to track hydration inParallel().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| api/v1_playlist_tracks.go | Ensures playlist track listing hydration includes unlisted tracks. |
| api/dbv1/playlists.go | Ensures playlist hydration includes unlisted tracks when loading tracks in parallel. |
| api/dbv1/parallel.go | Adds/propagates IncludeUnlisted through parallel track loading. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Covers both GET /v1/playlists/:id (hydrated tracks array) and GET /v1/playlists/:id/tracks with unlisted track fixtures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_tracksquery'sis_unlisted = falsefilterplaylist_contentslisted the track ID but the hydratedtracksarray was missing itIncludeUnlisted: truefor bothGET /v1/playlists/:id(viaParallelParams) andGET /v1/playlists/:id/tracksTest plan
GET /v1/playlists/:idand verify the track appears in thetracksarrayGET /v1/playlists/:id/tracksand verify unlisted tracks are included🤖 Generated with Claude Code