Skip to content

Use LATERAL joins for followee reposts/favorites queries #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickyrombo merged 1 commit into from
Apr 9, 2026
+100 −60
Merged

Use LATERAL joins for followee reposts/favorites queries #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 25 additions & 15 deletions api/dbv1/get_playlists.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 25 additions & 15 deletions api/dbv1/get_tracks.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 25 additions & 15 deletions api/dbv1/queries/get_playlists.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,19 +74,24 @@ SELECT
SELECT json_agg(
json_build_object(
'user_id', r.user_id::text,
'repost_item_id', repost_item_id::text, -- this is redundant
'repost_item_id', r.repost_item_id::text, -- this is redundant
'repost_type', 'RepostType.track', -- some sqlalchemy bs
'created_at', r.created_at -- this is not actually present in python response?
)
)
FROM (
SELECT user_id, repost_item_id, reposts.created_at
FROM reposts
JOIN my_follows USING (user_id)
WHERE repost_item_id = p.playlist_id
AND repost_type != 'track'
AND reposts.is_delete = false
ORDER BY follower_count DESC
SELECT mf.user_id, lr.repost_item_id, lr.created_at, mf.follower_count
FROM my_follows mf
CROSS JOIN LATERAL (
SELECT reposts.repost_item_id, reposts.created_at
FROM reposts
WHERE reposts.user_id = mf.user_id
AND reposts.repost_item_id = p.playlist_id
AND reposts.repost_type != 'track'
AND reposts.is_delete = false
LIMIT 1
) lr
ORDER BY mf.follower_count DESC
LIMIT 6
) r
)::jsonb as followee_reposts,
Expand All @@ -101,13 +106,18 @@ SELECT
)
)
FROM (
SELECT user_id, save_item_id, saves.created_at
FROM saves
JOIN my_follows USING (user_id)
WHERE save_item_id = p.playlist_id
AND save_type != 'track'
AND saves.is_delete = false
ORDER BY follower_count DESC
SELECT mf.user_id, ls.save_item_id, ls.created_at, mf.follower_count
FROM my_follows mf
CROSS JOIN LATERAL (
SELECT saves.save_item_id, saves.created_at
FROM saves
WHERE saves.user_id = mf.user_id
AND saves.save_item_id = p.playlist_id
AND saves.save_type != 'track'
AND saves.is_delete = false
LIMIT 1
) ls
ORDER BY mf.follower_count DESC
LIMIT 6
) r
)::jsonb as followee_favorites
Expand Down
40 changes: 25 additions & 15 deletions api/dbv1/queries/get_tracks.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,19 +107,24 @@ SELECT
SELECT json_agg(
json_build_object(
'user_id', r.user_id::text,
'repost_item_id', repost_item_id::text, -- this is redundant
'repost_item_id', r.repost_item_id::text, -- this is redundant
'repost_type', 'RepostType.track', -- some sqlalchemy bs
'created_at', r.created_at -- this is not actually present in python response?
)
)
FROM (
SELECT user_id, repost_item_id, reposts.created_at
FROM reposts
JOIN my_follows USING (user_id)
WHERE repost_item_id = t.track_id
AND repost_type = 'track'
AND reposts.is_delete = false
ORDER BY follower_count DESC
SELECT mf.user_id, lr.repost_item_id, lr.created_at, mf.follower_count
FROM my_follows mf
CROSS JOIN LATERAL (
SELECT reposts.repost_item_id, reposts.created_at
FROM reposts
WHERE reposts.user_id = mf.user_id
AND reposts.repost_item_id = t.track_id
AND reposts.repost_type = 'track'
AND reposts.is_delete = false
LIMIT 1
) lr
ORDER BY mf.follower_count DESC
LIMIT 3
) r
)::jsonb as followee_reposts,
Expand All @@ -134,13 +139,18 @@ SELECT
)
)
FROM (
SELECT user_id, save_item_id, saves.created_at
FROM saves
JOIN my_follows USING (user_id)
WHERE save_item_id = t.track_id
AND save_type = 'track'
AND saves.is_delete = false
ORDER BY follower_count DESC
SELECT mf.user_id, ls.save_item_id, ls.created_at, mf.follower_count
FROM my_follows mf
CROSS JOIN LATERAL (
SELECT saves.save_item_id, saves.created_at
FROM saves
WHERE saves.user_id = mf.user_id
AND saves.save_item_id = t.track_id
AND saves.save_type = 'track'
AND saves.is_delete = false
LIMIT 1
) ls
ORDER BY mf.follower_count DESC
LIMIT 3
) r
)::jsonb as followee_favorites,
Expand Down
Loading