Open
Conversation
|
Rewrite responsive styles for FanClubDetailContent: replace fixed px strings with numeric constants and add DESKTOP_NAV_WIDTH; compute the two-column breakpoint dynamically from theme spacing and nav width. Simplify styles to default to a single-column layout and enable a two-column layout via a computed media query, keeping the sidebar at a fixed width and capping the main column max width. Adjust ordering, widths, flex rules, and add explanatory comments to clarify layout behavior.
julianbaker
force-pushed
the
fanclub-breakpoints
branch
from
f7ab799 to
df7e927
Compare
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14081.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch doesnt include all your changes @dylanjeffers, but I wanted to take a swing at fixing the breakpoints on this page. I like the behavior I landed on here, that said, if the code is rubbish feel free to reject and reimplement lol.
