Skip to content

Fix double nested container on dropdown/select menus#14084

Draft
cursor[bot] wants to merge 1 commit intomainfrom
cursor/bug-triage-and-resolution-abc7
Draft

Fix double nested container on dropdown/select menus#14084
cursor[bot] wants to merge 1 commit intomainfrom
cursor/bug-triage-and-resolution-abc7

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor bot commented Apr 8, 2026

Summary

  • fixed dropdown/select/filter menus rendering with an extra nested container shell
  • applied the fix centrally in Harmony Menu so web and mobile-web menus share consistent rendering

Root Cause

Popup now renders its own bordered shell, while Menu content is wrapped in a bordered Paper. This caused two stacked containers for a single menu.

Fix

  • updated packages/harmony/src/components/internal/Menu.tsx to render Popup with shadow='flat'
  • added packages/harmony/src/components/internal/Menu.module.css and applied it to the popup wrapper to make the outer shell transparent/no border
  • preserved the existing inner Paper shell for menu border/shadow styling

Validation

  • attempted targeted typecheck for @audius/harmony, but local toolchain is missing tsc in this environment (tsc: not found)
  • code compiles logically and changes are scoped to shared menu shell rendering
Open in Web View Automation 

Co-authored-by: Ray Jacobson <raymondjacobson@users.noreply.github.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 8, 2026

⚠️ No Changeset found

Latest commit: 0a8c41f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🌐 Web preview ready

Preview URL: https://audius-web-preview-pr-14084.audius.workers.dev

Unique preview for this PR (deployed from this branch).
Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant