Skip to content

Conversation

@dfsm
Copy link
Contributor

@dfsm dfsm commented Oct 19, 2025

RootTabBar: Add iOS 26 Liquid Glass support and fix Settings tab label visibility

  • Add menuAppearance theme property support to RootTabBarController

    • Set overrideUserInterfaceStyle based on theme's menuAppearance
    • Clear appearance properties for iOS 26+ to enable Liquid Glass effect (fix root tab bar white background when in dark mode)
    • Maintain legacy appearance configuration for iOS 18 and earlier
  • Fix Settings tab label visibility issue

    • Add tabBarItem image setup to SettingsViewController.init()
    • Add themeDidChange() call in SettingsViewController.init()
    • Override themeDidChange() to handle tab bar label visibility
    • Ensures Settings tab follows showRootTabBarLabel theme property like other tabs

This makes the root tab bar adopt iOS 26's new Liquid Glass visual appearance while respecting the app's dark/light theme preference, and ensures all tabs consistently show/hide labels based on theme configuration.

…l visibility

- Add menuAppearance theme property support to RootTabBarController
  - Set overrideUserInterfaceStyle based on theme's menuAppearance
  - Clear appearance properties for iOS 26+ to enable Liquid Glass effect (fix opaque background issue)
  - Maintain legacy appearance configuration for iOS 18 and earlier

- Fix Settings tab label visibility issue
  - Add tabBarItem image setup to SettingsViewController.init()
  - Add themeDidChange() call in SettingsViewController.init()
  - Override themeDidChange() to handle tab bar label visibility
  - Ensures Settings tab follows showRootTabBarLabel theme property like other tabs

This makes the root tab bar adopt iOS 26's new Liquid Glass visual appearance while respecting the app's dark/light theme preference, and ensures all tabs consistently show/hide labels based on theme configuration.
@dfsm dfsm requested a review from nolanw October 19, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants