fix(builder): persist contractsDB across blocks within a checkpoint#21520
Open
spalladino wants to merge 4 commits intomerge-train/spartanfrom
Open
fix(builder): persist contractsDB across blocks within a checkpoint#21520spalladino wants to merge 4 commits intomerge-train/spartanfrom
spalladino wants to merge 4 commits intomerge-train/spartanfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PhilWindle
approved these changes
Mar 13, 2026
…checkpoint-builder-contracts-db
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When building multiple blocks within a single checkpoint, the
CheckpointBuilderwas creating a newPublicContractsDBinstance for each block. This meant that contracts deployed in an earlier block within the same checkpoint were not visible to subsequent blocks, causing calls to newly deployed contracts to fail.Approach
Move the
PublicContractsDBinstance to be a persistent field onCheckpointBuilder, initialized once in the constructor and shared across all blocks in the checkpoint. Wrap block building in checkpoint/commit/revert semantics on the contracts DB so that failed blocks don't leak state.Changes
contractsDBfrom a local variable inmakeBlockBuilderDepsto a class field onCheckpointBuilder. WrapbuildBlockincreateCheckpoint/commitCheckpoint/revertCheckpointcalls on the contracts DB.Fixes A-658