fix(aztec-nr): backport warn on unknown note type id to v4-next#21525
Merged
nchamo merged 3 commits intobackport-to-v4-next-stagingfrom Mar 14, 2026
Merged
Conversation
AztecBot
force-pushed
the
claudebox/backport-21491-note-hash-nullifier-v4
branch
2 times, most recently
from
83d080f to
dd85253
Compare
…ote_hash_and_nullifier (with conflicts)
The note_hash_and_nullifier test contract does not exist on this branch, so the test file addition is dropped. The core fix (warn_log_format in aztec.nr) applied cleanly.
warn_log_format is available via aztec::protocol::logging. No adaptations required.
AztecBot
force-pushed
the
claudebox/backport-21491-note-hash-nullifier-v4
branch
from
dd85253 to
dc8f29b
Compare
nchamo
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21491 to v4-next.
Adds a
warn_log_formatcall in the macro-generated_compute_note_hash_and_nullifierfunction when an unknownnote_type_idis encountered, instead of silently returningNone.Conflict Resolution
The automatic cherry-pick failed because the
note_hash_and_nullifiertest contract (added in #21491) does not exist on v4-next. The test file was dropped since the parent contract is not present on this branch. The core fix inaztec.nrapplied cleanly.Commits
warn_log_formatis available viaaztec::protocol::loggingClaudeBox log: https://claudebox.work/s/adb5fe7dd704eb26?run=1