Open
Conversation
PhilWindle
reviewed
Mar 13, 2026
| if (context.event === EvictionEvent.BLOCK_MINED) { | ||
| const blockNumber = context.block.getBlockNumber(); | ||
| await this.worldState.syncImmediate(blockNumber); | ||
| const syncedTo = await this.worldState.syncImmediate(blockNumber, true); |
Collaborator
There was a problem hiding this comment.
I'm not sure this is the right approach. I suspect what happened here is
- Block 4425 was pruned and immediately replaced.
- We called
await this.worldState.syncImmediate(blockNumber)and at the time, I suspect the world state was synced to the old block 4425 so happily returned. - Then it processed the prune, so by the time we went to query it, the block was gone and it hadn't processed the new block.
I think if we simply call await this.worldState.syncImmediate(), with no args, this will forc the world state to do a full sync against the latest archiver state. Processing both the pruned block and the newly added replacement.
Contributor
There was a problem hiding this comment.
I've pushed #21556 after seeing this, what do you guys think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix A-661