fix(kv-store): make LMDB clear and drop operations atomic across sub-databases#21539
Open
Maddiaa0 wants to merge 1 commit intomerge-train/spartanfrom
Open
fix(kv-store): make LMDB clear and drop operations atomic across sub-databases#21539Maddiaa0 wants to merge 1 commit intomerge-train/spartanfrom
Maddiaa0 wants to merge 1 commit intomerge-train/spartanfrom
Conversation
Maddiaa0
force-pushed
the
fix/130-lmdb-non-atomic-clear
branch
from
5f606aa to
53392a6
Compare
…databases Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Maddiaa0
force-pushed
the
fix/130-lmdb-non-atomic-clear
branch
from
53392a6 to
fba3d29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #21514
Summary
AztecLmdbStore.clear()anddrop()called their respective operations on each sub-database (#data,#multiMapData,#rootDb) sequentially without a wrapping transaction. A crash between operations could leave the store in an inconsistent state (some sub-DBs cleared, others not).this.#rootDb.transaction()call using synchronous variants (clearSync()/dropSync()) so they execute atomically.Changes
yarn-project/kv-store/src/lmdb/store.ts:clear()now usesclearSync()inside a transaction;drop()now usesdropSync()inside a transaction.yarn-project/kv-store/src/lmdb/store.test.ts: New test file with 7 test cases.Test plan
clear(),drop(), anddelete()operationsyarn workspace @aztec/kv-store test🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com