fix(stdlib): prevent precision loss in GasFees.mul() for large bigint values#21544
Open
fix(stdlib): prevent precision loss in GasFees.mul() for large bigint values#21544
Conversation
… values The old code converted bigint fees to Number before multiplying by a fractional scalar, losing precision for values above 2^53. Use scaled bigint arithmetic (mulDiv with ceiling) at 18 decimal precision instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #21514
Summary
Previously truncated this to number which is risky for lossyness, this pr implements mulDiv with 18 decimal base - same as solidity bigint math
Callers
All production callers pass small fractional scalars (1.0–2.0 range):
wallet.mul(1 + this.minFeePadding)where padding defaults to 0.5fees.mul(1.5)in e2e testsgas.mul(1 + pad)in gas limit estimation