fix(txe): await using for world state fork#21555
Open
Maddiaa0 wants to merge 1 commit intomerge-train/spartanfrom
Open
fix(txe): await using for world state fork#21555Maddiaa0 wants to merge 1 commit intomerge-train/spartanfrom
Maddiaa0 wants to merge 1 commit intomerge-train/spartanfrom
Conversation
…ed world trees The mineBlock method was closing the forked world trees before calling handleL2Block. Reorder so handleL2Block runs while the fork is still open, and use `await using` for automatic cleanup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Maddiaa0
changed the title
Member
Author
|
@AztecBot run prettier in yarn project on this then squash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of: #21514
Summary
mineBlockin the TXE oracle was closing forked world trees before callinghandleL2Block, which is inconsistent with every other block-building flow in the codebaseawait usingfor the forked trees, ensuring automatic cleanup and guaranteeinghandleL2Blockcompletes before disposeTest plan
handleL2Blockis called before the fork is closed🤖 Generated with Claude Code