fix(archiver): guard getL1ToL2Messages against incomplete message sync (backport #21494)#21558
Closed
AztecBot wants to merge 1 commit intobackport-to-v4-next-stagingfrom
Closed
fix(archiver): guard getL1ToL2Messages against incomplete message sync (backport #21494)#21558AztecBot wants to merge 1 commit intobackport-to-v4-next-stagingfrom
AztecBot wants to merge 1 commit intobackport-to-v4-next-stagingfrom
Conversation
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21494 to v4-next.
getL1ToL2Messages(checkpointNumber)now throwsL1ToL2MessagesNotReadyErrorif the requested checkpoint's message tree hasn't been sealed on L1 yet (i.e.,checkpointNumber >= inbox treeInProgress). This prevents callers from deriving incorrectinHashvalues from incomplete data.Conflicts resolved
OutOfOrderLogInsertionErrorclass from surrounding context onnextdoes not exist onv4-next— kept only the newL1ToL2MessagesNotReadyErrorclass.OutOfOrderLogInsertionErrorimport that doesn't exist onv4-next.Test plan
yarn build)kv_archiver_store.test.tsinbox tree guard tests pass (3/3)archiver-sync.test.tsall tests pass (32/32)ClaudeBox log: https://claudebox.work/s/5a11777010141fb0?run=3