You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The contracts in this repo have not had an external security review, and nothing in the README says so. Anyone landing on the repo (or the npm package) can reasonably read "comprehensive collection of reusable, standardized contracts" as production-ready. Until an audit happens, the unaudited status should be stated prominently and unambiguously.
What
Adds an ⚠️ Security Status: Unaudited section immediately below the intro, using the conventional wording for unaudited smart-contract releases: no external review / audit / formal verification, may contain bugs or vulnerabilities leading to irrecoverable loss of funds, provided "AS IS" without warranties, use at your own risk, obtain your own independent review. Rendered as a GitHub [!WARNING] callout so it stands out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The contracts in this repo have not had an external security review, and nothing in the README says so. Anyone landing on the repo (or the npm package) can reasonably read "comprehensive collection of reusable, standardized contracts" as production-ready. Until an audit happens, the unaudited status should be stated prominently and unambiguously.
What
[!WARNING]callout so it stands out.LICENSE(MIT, © 2024 Wonderland) — the README did not mention the licence at all, and the disclaimer's "AS IS, without warranties" language leans on it. Happy to drop this hunk if you'd rather keep the PR to the warning alone.No code or test changes.
Notes
src/*/README.mdare untouched — say the word if you want the notice mirrored there too.Created by claudebox · group:
slackbot· requested by Michael Connor · Slack thread